From 167ad2f877637474095c989f99801f046dc3b5bc Mon Sep 17 00:00:00 2001 From: ukr8b3g-cmyk Date: Tue, 25 Aug 2026 00:21:39 +0900 Subject: [PATCH] docs: clarify conditional reference size controls --- MANIFEST.sha256 | 4 ++-- PROJECT_STATE.md | 6 ++++++ README.md | 9 +++++++++ README_JA.md | 9 +++++++++ WORKLOG.md | 7 +++++++ 5 files changed, 33 insertions(+), 2 deletions(-) diff --git a/MANIFEST.sha256 b/MANIFEST.sha256 index ad9fd42..4bc1eab 100644 --- a/MANIFEST.sha256 +++ b/MANIFEST.sha256 @@ -74,8 +74,8 @@ ef705a476e3f5bbd05559e7a0e7d3dfb9275badef0f8f65fb1a36ce27fbcb537 model_patch.py b470819f16fc179654dc1600721a63f0a5a14e777f4c004d574b499da6886ba5 public_api.py 4015160058bc975f4ec85f59d41a6b57e95163090328e129df6b74738743cdad pyproject.toml 94fdc2d545b2d4077a4d70229fd22ba3ccac21d49d1097d2873f76d04e9a3c7a pytest.ini -5417c78bac0bc1079a559d81d7aef499c110e3aa3e2016aaba5a6be840131b58 README_JA.md -10fc595d81b67c61408d51635a3c6b407d9bd3a28a079a2e0f4223f22f284416 README.md +9c70a65bc6892ae886f2deb46297149063d69b2759ce4035b349f4e47331e5e7 README_JA.md +798b8dba3931cda9aea73d4d51ebaef83224cf7a11a2e329a32acd31fdc65a80 README.md 5d89c366b4f076fa73a2695557e0af749bf95df1dad0d55dbb2fe5b1c2519ad7 reference_audio.py 8f1744dc99f1a3a222b7d6e986f6dac1edcc0abbbe8b61a1d2606b1ca3569b3d reference_video.py 2995924fcb7bac27b548b01187d8276d2ab103c6f43416cf85400de3846c6297 reference.py diff --git a/PROJECT_STATE.md b/PROJECT_STATE.md index ed41385..3dd757c 100644 --- a/PROJECT_STATE.md +++ b/PROJECT_STATE.md @@ -333,3 +333,9 @@ Static checks do not replace a real GPU generation. Record workflow, prompt, med - Public GPU limits now distinguish accepted 1x5 576-to-1152 Main and Hybrid/Reference paths from the unaccepted 3x5 2x RTX 5060 Ti 16 GiB condition, which failed at the terminal 77T group's first Second Pass inference after the 37T group completed. - Final source validation is `430 passed`; all 159 Manifest entries verify by SHA-256; `git diff --check` passes. ComfyUI_W runtime verifier passes package 3.5.0 registration, native PackedLayout, and Fixed 3x5 planning. Nine changed public documentation/assets match the snapshotted runtime by SHA-256. - Verified pre-release snapshots are `pre-v35-formal-readme-release-source-verified-20260824_141358` (431 files) and `pre-v35-formal-readme-release-runtime-w-verified-20260824_141359` (334 files), excluding `.git` and the pre-existing inaccessible `.pytest_cache`. + +## Issue #11 documentation clarification (2026-08-25) + +- `Reference Size` and `Video Guide Size` are existing V3.5 controls, not missing inputs. Compact UI reveals them only after a corresponding Reference Image or Video Guide Frames connection. +- `Video Guide Size` is the V3.5.1 display name for the earlier `Video Reference Size`; the backend key and saved-workflow compatibility are unchanged. +- Reference Images and Video Guide Frames are resized internally before VAE encoding. External resize remains optional for deliberate crop, forced source upscaling, or a custom algorithm; loader-side decoding and frame-rate conversion remain unchanged. diff --git a/README.md b/README.md index 061f171..43f18e4 100644 --- a/README.md +++ b/README.md @@ -218,6 +218,15 @@ Driving Audio is the primary V3.4 audio path. | Balanced - 0.6 MP | More detail at a higher compute cost. | | Match Output | Largest reference input; potentially much slower and heavier. | +#### Conditional size controls and internal resize + +The compact V3.5 UI shows each size control only when its corresponding input is connected: + +- Connect any of `reference_image_1` through `reference_image_3` to reveal `Reference Size`. +- Connect `Video Guide Frames` to reveal `Video Guide Size`. Earlier workflows and reports may call this control `Video Reference Size`; V3.5.1 uses the clearer display name `Video Guide Size` while preserving the existing backend key and saved-workflow compatibility. + +These controls are therefore not missing from a newly created node; they are hidden until relevant. Reference Images and Video Guide Frames are resized internally before VAE encoding. Video Guide Frames preserve their aspect ratio, align to the H3 canvas, and use Lanczos when reduction is needed. Smaller sources are not enlarged automatically. An external resize node is normally unnecessary, but remains useful for deliberate cropping, forced upscaling of a small source, or a custom resize/upscale algorithm. Video decoding and frame-rate conversion remain the loader's responsibility. + ### Hybrid First/Last Frame + Reference Images You need an hybrid version of MiniMax-H3 to make both I2V and reference images work: diff --git a/README_JA.md b/README_JA.md index 696cfee..f9882a6 100644 --- a/README_JA.md +++ b/README_JA.md @@ -145,6 +145,15 @@ V3.4.0は、最大3枚のReference Image、Run Storage、Spectrum Interop、Deco `Driving Audio`は入力音声を絶対時間で各Chunkのガイドに使い、最終出力には元音声を維持します。`Video Guide Frames`はVideo loaderが出力したIMAGE frame batchを全Chunkで継続使用し、`Efficient - 0.4 MP`、`Balanced - 0.6 MP`、`Match Output`から処理解像度を選択できます。青いIMAGE socketですが、通常の1枚の静止画参照ではなく動画フレーム列を接続します。 +### Size項目の条件付き表示と内部Resize + +V3.5のCompact UIでは、対応する入力を接続した時だけSize項目を表示します。 + +- `reference_image_1`~`reference_image_3`のいずれかを接続すると、`Reference Size`を表示します。 +- `Video Guide Frames`を接続すると、`Video Guide Size`を表示します。以前のWorkflowやIssueで`Video Reference Size`と記載されている項目と同じもので、V3.5.1では表示名だけを`Video Guide Size`へ明確化し、既存のbackend keyと保存済みWorkflowの互換性を維持しています。 + +したがって、新規ノードで見えないSize項目は欠落ではなく、未接続のため非表示になっています。Reference ImageとVideo Guide FramesはVAE Encode前に内部Resizeされます。Video Guide Framesはアスペクト比を維持してH3 canvasへ整列し、縮小が必要な場合はLanczosを使用します。小さい入力を自動的に拡大はしません。通常は外部Resizeノードを必要としませんが、意図的なcrop、小さい素材の強制upscale、独自のresize/upscale方式を使う場合には外部処理を利用できます。動画のdecodeとframe-rate変換は引き続きloader側の責任です。 + Reference入力のバイパスされたソケットは無視され、有効な画像だけがPicture 1から連続採番されます。空欄や不完全なプロンプトも停止せず、警告とFixed fallbackで生成を続行します。未知のモデル、ノード、プロンプト形式を独自判断で拒否する制限も撤廃しました。 Run Storageの保存契約にはDriving AudioとVideo Guide Framesのidentityを含め、入力変更後に古いChunkを誤再利用しないようにしています。 diff --git a/WORKLOG.md b/WORKLOG.md index 2b15802..2b7cf7c 100644 --- a/WORKLOG.md +++ b/WORKLOG.md @@ -396,3 +396,10 @@ D:\Codex\_snapshots\ComfyUI-H3-Continuum\pre-rollback-after-00038-fail-20260821_ - Final release checks: canonical ComfyUI_W-root pytest `450 passed` with only the known `pynvml` warning; JavaScript syntax and `git diff --check` pass; all 172 Manifest entries and README image/workflow references verify. - Added the user-supplied LBH + Conditioning Bridge workflow as a separate public connection example and a lightweight SVG flow chart to both README editions. The recommended template remains unchanged, and Core nodes retain their standard display titles. - Synchronized only the relevant implementation/tests to ComfyUI_W and verified per-file SHA-256 equality. No ComfyUI process was started or stopped. Commit/push not performed. + +## 2026-08-25 - Issue #11 conditional size-control documentation + +- Confirmed that Issue #11 reports a discoverability/documentation gap rather than missing V3.5.1 inputs: Compact UI hides `Reference Size` and `Video Guide Size` until their matching image inputs are connected. +- Added matching English/Japanese README guidance covering the conditional display, the `Video Reference Size` to `Video Guide Size` display-name clarification, internal aspect-preserving resize before VAE encoding, the no-automatic-upscale behavior, and the limited cases where external resize is useful. +- No node schema, backend key, workflow, runtime implementation, Sampling, Conditioning, Terminal Merge, Assembly, Seam, or Run Storage behavior changed. +- Pre-change snapshot: `pre-issue11-readme-clarification-source-accepted-20260825_001938` (478 files), excluding `.git` and the known ACL-inaccessible `.pytest_cache` after the standard snapshot script encountered that existing ACL condition.