fix(v3.8): exclude render history from workflow serialization

Ref #20. Add store-persistence regression and preserve all backend/widget contracts. Live browser and broader loader resets remain unverified.
This commit is contained in:
github-actions[bot]
2026-09-10 03:49:52 +00:00
parent 6b453fed74
commit 17d8f408c5
7 changed files with 93 additions and 10 deletions
+6 -6
View File
@@ -86,8 +86,8 @@ a4ce23167b83e8d72b86a802dfde4f4045828433c7c13aab799bd64831dc04a4 nodes.py
b470819f16fc179654dc1600721a63f0a5a14e777f4c004d574b499da6886ba5 public_api.py
96f98d727b72d6aefd431061572e187c303365a3e5b4d20cbb2bcf030aa30112 pyproject.toml
94fdc2d545b2d4077a4d70229fd22ba3ccac21d49d1097d2873f76d04e9a3c7a pytest.ini
88aa955161d04d14ebd8d90d6cb6c6206097160a671eb4d1bfe9b3e76ebc6c13 README_JA.md
9d9fa5ec9db29e2fb52e3c5ed26df02c9c0c2ba39608294f7c62057237830908 README.md
f13cdf0a4ddc7943b6a464d50547d8603a0dfdfc8c970e0a601e276cb281b54f README_JA.md
44076d133dfcd4df14de95c92e6cff19bd1be5c381f200d061c67d382d202996 README.md
44127adcfa30ee84bff9cd4b2d0c695355209550e76982d374122008728aa5bc reference_audio.py
5cb9bfd6810d3a93a637451980a4cc5c1436e5b84cfd1c7a111cd192e876351b reference_video.py
131bdfbb7a7173c9e7826859c0e648bfb69bd18bf20fa5528c0e18a63f888b26 reference.py
@@ -97,7 +97,7 @@ b470819f16fc179654dc1600721a63f0a5a14e777f4c004d574b499da6886ba5 public_api.py
3a359a0467725cc292ccb4c86cf0c3d30bb6a114d01f5345792b09ea3d45441d state.py
43ec4023dc06c941e5d7a04db4b8a89fb58d744ceb986f6eb9bf534d4fdcb87b temporal.py
db08ce77cc5c5835f2403d4d589394090fa5d25ff3b1840312b2808e1bc203b7 tests/fixtures/v38_a3c_selective_refine_saved_workflow.json
f24c2739f62eb44612565d00effb6a3813653901f94dafd35eb1a519a989c569 tests/conftest.py
e6506f7ee87f59c25e05156f6b9a835ef78443dcf6f0435c48675dda0c0dd63d tests/conftest.py
041289556cc621ea1857cbb8931ae41d817f69e084b2e8a7622e184a3197b61b tests/test_compatibility.py
875ac33b5458ec5e8d845850ed495707c394436aaadb668a44f36f6a1b73764d tests/test_conditioning_modes.py
2be669b6d21ec40a8b0e172b8ab431f82681f3c97c7de0935d87ad43b0ae8b4e tests/test_context_diagnostics.py
@@ -241,12 +241,12 @@ c2883272b05a9a9146b5c6cf614ddae8a3e6893cd910902023aae61360195289 web/easy_bypas
9db0aa94f634578a962d5db49e5c70356040a59df968e3a2e531b327a623081f web/easy_load_image.js
873efcbd15c2d9fa10c9d5fc51a796ad3a18c0c6acceecf499c4b956aa845c6c web/easy_load_video.js
0c68d13a1f8beb7431a32b471f8b0612c42fcc4bf72dd97611a025d158008662 web/easy_v38.js
9ff85ff814e53b45fdc7bb3de3ccd85f80ca2ecb301f5d2d519d1dcc6e9aac87 web/project_id.js
045b8154ef5c5b2839d87b685ebc875d4f8fb98ddf1571fc58fd73a558bc0eaa web/project_id.js
be0b8d39e5343680ebea815c3a4fb6ce7a32e065f30e43e013040a40f702cef3 .comfyignore
1d2838cc47694609289ea15132872ad48e1b6c8274da4b7bf188dd3ebf066121 docs/V38_RELEASE_AND_MIGRATION.md
abaaf46043bc17958bbe2d22c7961993682c49a3ac37d44ef68aa2133482a539 tests/test_v38_public_surface_cleanup.py
0cf8d49bcb71b30437dc893f6218dc4cfb1cd244b647e4fbc2861dea2271a33a web/reference_audio_ui.js
1f3b4189be26ef18fa7c88f366f96904c985be759cdb00f7a18482eb00aad08b REGISTRY_MANIFEST.sha256
b165ea2c599c5be1b6c0cf23dce09021f94a8e0e10c284a578c9b705de2f0f5e REGISTRY_MANIFEST.sha256
717577efdec5e61600504b77bc2a099ef022c4fe2333e936c3310c7182d8f2a0 docs/V38_OPEN_INTEGRATION_CONTRACT.md
623d528a02b6712cba28c374ba3ad979bc84e2ac5318640692589a04ba6ab15f tests/test_v38_open_integration_contract.py
0bc369ee428b8a5bc8e370a81fbab427262a1fdb7805a78c442c91698d65efba tools/__init__.py
@@ -254,5 +254,5 @@ abaaf46043bc17958bbe2d22c7961993682c49a3ac37d44ef68aa2133482a539 tests/test_v38
bb5a1530c890d357dc48ea74039340d746e876e8f85e06d4d9a19369f8ff5961 tests/test_v38_hover_help.py
3d681ded5d4c50cc20c2382e29fdc98d8a48e76d552c41ad5a195d941e66e612 .gitattributes
83d28cc0cd549066962dc21ceae05d2b189fe22391b556887eab2cc1800e1e80 examples/workflows/MiniMax_H3_Continuum_V38.zip
9d50a06395b6294f9da3810263357b25a26f64ec77b3ca97ddeb8c242f0ab969 tests/frontend_review_queue.cjs
089c544b897c00a88f391c96b677739fae817ac4d57f4ac644762befb3465480 tests/frontend_review_queue.cjs
c98ef5e0431c1dc071e0a18a5904e57fb4b6d226ea5f5996756876cc93173607 tests/test_v38_completed_review_ui.py
+6
View File
@@ -1,5 +1,11 @@
# Project State
## Issue #20 workflow persistence hotfix (2026-09-10)
- User authorized repair and publication to main from pinned 6b453fe. The only runtime change is `serialize: false` on the read-only Render History widget in `web/project_id.js`; existing `options.serialize: false` is retained. Backend widget order, Sampling, Audio, Run Storage, public workflow/ZIP bytes, and Easy Loader Bypass behavior are unchanged.
- Added a regression using the real Continuum frontend script with modeled compact store persistence and forceInput migration. It covers ordinary serialization, store serialization, positional/named round trips, Advanced/Review/History/completion views, and API-input parity. It fails on the unmodified runtime; all 45 pre-existing fixture cases remain green. Full CPU pytest: 1154 passed, 2 skipped; frontend fixture: 46/46 passed.
- Validation ran on an isolated GitHub Actions CPU runner after byte-verified snapshots made with `tools/snapshot.ps1`. This is not a real-browser or GPU validation. Windows source/runtime and saved Takes were not accessed or changed. Existing corrupted workflows need separate recovery; model/VAE/LoRA reset reports and the separate Bypass issue remain unverified. No Release/tag or Registry publication. Fixed H3情報チェック cross-task handoff was not sent from this session.
## Review boundary repair — CPU validated, live 3x5 pending (2026-09-08)
- The latest actual Review Queue did not generate Chunk 1: backend history proved it reused all three saved chunks and returned the prior `complete` revision. The previous mode-selection presentation repair therefore did not satisfy the user's acceptance condition and is superseded by this entry.
+3 -3
View File
@@ -27,8 +27,8 @@ a4ce23167b83e8d72b86a802dfde4f4045828433c7c13aab799bd64831dc04a4 nodes.py
000a56a942b13d11973994ab32cd2a1abc424a3fe1d95a323240077bd8092bdf PACKAGE_VALIDATION.txt
b470819f16fc179654dc1600721a63f0a5a14e777f4c004d574b499da6886ba5 public_api.py
96f98d727b72d6aefd431061572e187c303365a3e5b4d20cbb2bcf030aa30112 pyproject.toml
88aa955161d04d14ebd8d90d6cb6c6206097160a671eb4d1bfe9b3e76ebc6c13 README_JA.md
9d9fa5ec9db29e2fb52e3c5ed26df02c9c0c2ba39608294f7c62057237830908 README.md
f13cdf0a4ddc7943b6a464d50547d8603a0dfdfc8c970e0a601e276cb281b54f README_JA.md
44076d133dfcd4df14de95c92e6cff19bd1be5c381f200d061c67d382d202996 README.md
44127adcfa30ee84bff9cd4b2d0c695355209550e76982d374122008728aa5bc reference_audio.py
5cb9bfd6810d3a93a637451980a4cc5c1436e5b84cfd1c7a111cd192e876351b reference_video.py
131bdfbb7a7173c9e7826859c0e648bfb69bd18bf20fa5528c0e18a63f888b26 reference.py
@@ -100,6 +100,6 @@ c2883272b05a9a9146b5c6cf614ddae8a3e6893cd910902023aae61360195289 web/easy_bypas
9db0aa94f634578a962d5db49e5c70356040a59df968e3a2e531b327a623081f web/easy_load_image.js
873efcbd15c2d9fa10c9d5fc51a796ad3a18c0c6acceecf499c4b956aa845c6c web/easy_load_video.js
0c68d13a1f8beb7431a32b471f8b0612c42fcc4bf72dd97611a025d158008662 web/easy_v38.js
9ff85ff814e53b45fdc7bb3de3ccd85f80ca2ecb301f5d2d519d1dcc6e9aac87 web/project_id.js
045b8154ef5c5b2839d87b685ebc875d4f8fb98ddf1571fc58fd73a558bc0eaa web/project_id.js
0cf8d49bcb71b30437dc893f6218dc4cfb1cd244b647e4fbc2861dea2271a33a web/reference_audio_ui.js
83d28cc0cd549066962dc21ceae05d2b189fe22391b556887eab2cc1800e1e80 examples/workflows/MiniMax_H3_Continuum_V38.zip
+7
View File
@@ -1831,3 +1831,10 @@ D:\Codex\_snapshots\ComfyUI-H3-Continuum\pre-rollback-after-00038-fail-20260821_
- Classification: feature exists and the backend rejection was safe; frontend catalog eligibility and rendering were defective. Fixed by filtering to canonical-lineage, fully resolvable ancestry; stale selections automatically return to a canonical Take with `Automatic` action. History output is compact and draw-height independent.
- Focused Review/History regression `59 passed`; full CPU regression `1156 passed` in `52.09s`. Runtime deployment changed only `web/project_id.js` after Queue `0/0`; source/runtime SHA-256 match at `549A8150BC926BF142758B1610E3730547D6ABCFBCDDB0B37ED8BAAAF86B38CB`. Runtime snapshot: `D:\Codex\_snapshots\ComfyUI-H3-Continuum\before-v38-render-history-runtime-deploy-20260908_162700`.
- No Take was adopted and no generation was started by Codex. Live browser confirmation is pending reload because the existing ComfyUI tab is marked unsaved; it was not forcibly reloaded.
## Issue #20 workflow persistence hotfix (2026-09-10)
- User authorized repair and publication to main from pinned 6b453fe. The only runtime change is `serialize: false` on the read-only Render History widget in `web/project_id.js`; existing `options.serialize: false` is retained. Backend widget order, Sampling, Audio, Run Storage, public workflow/ZIP bytes, and Easy Loader Bypass behavior are unchanged.
- Added a regression using the real Continuum frontend script with modeled compact store persistence and forceInput migration. It covers ordinary serialization, store serialization, positional/named round trips, Advanced/Review/History/completion views, and API-input parity. It fails on the unmodified runtime; all 45 pre-existing fixture cases remain green. Full CPU pytest: 1154 passed, 2 skipped; frontend fixture: 46/46 passed.
- Validation ran on an isolated GitHub Actions CPU runner after byte-verified snapshots made with `tools/snapshot.ps1`. This is not a real-browser or GPU validation. Windows source/runtime and saved Takes were not accessed or changed. Existing corrupted workflows need separate recovery; model/VAE/LoRA reset reports and the separate Bypass issue remain unverified. No Release/tag or Registry publication. Fixed H3情報チェック cross-task handoff was not sent from this session.
+1 -1
View File
@@ -37,7 +37,7 @@ def review_queue_results():
capture_output=True, text=True, encoding="utf-8", timeout=45,
)
records = json.loads(result.stdout)
assert len(records) == 45, "The complete queue fixture must finish, including three duration-input cases"
assert len(records) == 46, "The complete queue fixture must finish, including duration-input and Issue 20 persistence cases"
failures = [item for item in records if not item["pass"]]
assert result.returncode == 0 and not failures, result.stdout + result.stderr
return {item["name"]: item for item in records}
+69
View File
@@ -371,6 +371,75 @@ await test('same completed revision reuse exits setup without new Sampling',asyn
assert(!n.__h3ContinuumModeSetup);assert(e.visible(n,'Try this chunk again'));assert(e.visible(n,'Start again from Chunk 1'));
assert(!e.visible(n,'Use it and continue'));assert.equal(e.submissions.length,1);
});
await test('Issue 20 store persistence excludes transient UI across reloads',async e=>{
// Model the compact store serializer, which does NOT call node.serialize().
// The flag contract is from ComfyUI_frontend 77bdc5d LGraphNode.ts.
// Real Continuum UI creation/refresh runs through the existing environment.
const n=e.makeNode();await e.load(n,null);
const persistent=()=>n.widgets.filter(w=>!w.__h3ContinuumProductionTransient);
const values=()=>persistent().map(w=>structuredClone(w.value));
const storeSave=()=>{
const widgets=n.widgets.filter(w=>w.serialize!==false);
return {widgets_values:widgets.map(w=>structuredClone(w.value)),
widgets_values_named:Object.fromEntries(widgets.map(w=>[w.name,structuredClone(w.value)]))};
};
// Array-only projection of Core's forceInput migration in litegraphUtil.ts.
// A leaked history value makes 30 values look like a 31-value legacy payload.
const migrate=(widgets,saved)=>{
const defs=[{name:'sequence_prompt',forceInput:true},
...persistent().filter(w=>w.name!=='control_after_generate')
.map(w=>({name:w.name,control_after_generate:w.name==='base_seed'}))];
const names=new Set(widgets.map(w=>w.name));
const skipped=new Set(widgets.filter(w=>w.serialize===false).map(w=>w.name));
const mask=defs.filter(d=>names.has(d.name)||d.forceInput).flatMap(d=>
skipped.has(d.name)?[]:d.control_after_generate?[!!d.forceInput,false]:[!!d.forceInput]);
const count=widgets.filter(w=>w.serialize!==false).length;
if(!mask.includes(true)&&saved.length===count)return saved;
const compacted=saved.filter((_,i)=>widgets[i]?.serialize!==false);
const aligned=compacted.length===mask.length?compacted:saved.length===mask.length?saved:undefined;
return aligned?aligned.filter((_,i)=>!mask[i]):saved;
};
const verify=async()=>{
const expected=values();assert.equal(expected.length,30);
const saved=storeSave();
assert.equal(saved.widgets_values.length,30,'UI-only history leaked into workflow persistence');
assert.deepEqual(saved.widgets_values,expected);
assert.deepEqual(n.serialize().widgets_values,expected);
assert.deepEqual(Object.keys(saved.widgets_values_named),persistent().map(w=>w.name));
for(const w of n.widgets.filter(w=>w.__h3ContinuumProductionTransient)){
assert.equal(w.serialize,false,`${w.name}: workflow exclusion`);
assert.equal(w.options?.serialize,false,`${w.name}: API exclusion`);
}
const apiBefore=await e.inputs(n);
assert(!Object.hasOwn(apiBefore,'Render History / Takes'));
for(const named of [false,true]){
for(let i=0;i<3;i++){
const data=JSON.parse(JSON.stringify(storeSave()));
const canonical=persistent();
const migrated=migrate(canonical,data.widgets_values);
assert.deepEqual(migrated,expected);
if(named){
for(const w of canonical)w.value=structuredClone(data.widgets_values_named[w.name]);
}else n.configure({widgets_values:migrated});
e.f.configureNode(n);
assert.deepEqual(values(),expected);
assert.equal(e.w(n,'Prompt Format').value,e.w(n,'prompt_mode').value);
assert.equal(e.w(n,'Height').value,e.w(n,'height').value);
}
}
assert.deepEqual(await e.inputs(n),apiBefore);
};
// Empty history, ordinary settings, expanded controls, Review and completion.
e.w(n,'Chunks').callback(6);e.w(n,'Seconds per Chunk').callback(2.5);
e.w(n,'Width').callback(640);e.w(n,'Height').callback(768);
await verify();
e.w(n,'Advanced Settings').callback();await verify();
e.w(n,'generation_mode').value='Review Each Chunk';await e.load(n,project(1,6));
await verify();e.w(n,'Render History').callback();await verify();
e.w(n,'Back to Settings').callback();await verify();
e.w(n,'Return to Review').callback();await verify();
await e.load(n,project(6,6,'complete'));await verify();
});
await test('mode policy and transient UI serialization remain stable',async e=>{
const n=e.makeNode();e.w(n,'run_storage').value='Off';e.w(n,'Run').callback('Review Each Chunk');
assert.equal(e.w(n,'run_storage').value,'Save + Auto Resume');e.w(n,'Run').callback('Generate Full Video');
+1
View File
@@ -2309,6 +2309,7 @@ function configureProductionReviewUx(node) {
type: "h3_continuum_take_history",
name: TAKE_STATUS_WIDGET,
value: "No Render History yet",
serialize: false,
options: { serialize: false },
[PRODUCTION_TRANSIENT_WIDGET]: true,
draw(ctx, _node, width, y, height) {