fix(ui): stabilize V3.8 review and render history
This commit is contained in:
@@ -1,5 +1,19 @@
|
||||
# Project State
|
||||
|
||||
## Review boundary repair — CPU validated, live 3x5 pending (2026-09-08)
|
||||
|
||||
- The latest actual Review Queue did not generate Chunk 1: backend history proved it reused all three saved chunks and returned the prior `complete` revision. The previous mode-selection presentation repair therefore did not satisfy the user's acceptance condition and is superseded by this entry.
|
||||
- Source now treats an explicit Full Video -> Review Each Chunk selection as a new non-destructive review series. Before Queue it refreshes canonical Run Storage state; when saved `review_ready` or `complete` history exists, only the queued payload receives `Regenerate From = Chunk 1`, automatic nonce, and no Take selection. The visible settings and saved Takes remain unchanged. The first actual Sampler result releases setup mode and loads its canonical review state; later Continue queues inherit that new branch and advance one physical group at a time.
|
||||
- Exact CPU contracts cover `3 x 5s`: fresh Chunk 1 -> review, Continue -> Chunk 2 review, Continue -> Chunk 3 complete. The real frontend lifecycle and backend branch/nonce resolver pass. Focused Review/UI suite `123` PASS and full CPU suite `1156/1156` PASS in `50.69s`; Registry/source declarations, JavaScript syntax and `git diff --check` pass. Evidence: `D:\Codex\_test_results\ComfyUI-H3-Continuum\v38-review-boundary-20260908`.
|
||||
- Fixed H3情報チェック returned `PASS / local runtime deploy OK`; its nonblocking queued-identity note was applied by binding setup release to the exact setup token and Run name. Installed ComfyUI_W still has the superseded frontend SHA `d84877206cc1142dbfe7fce3f7e9c1b6edb8a22cae5ab117a1407f9435f6dea7`; validated source SHA is `fe5e00020b9e942ec2e27286576aca69fb3add3f18afeea8edcfd28f6183cd91`. Runtime deployment, browser refresh and actual GPU `3 x 5s` Chunk1/2/3 screen acceptance remain pending. No workflow, Production/Sampling backend, saved Take, commit, push, tag or release change.
|
||||
|
||||
## Local Review mode-selection repair (2026-09-08)
|
||||
|
||||
- Deployed locally after H3情報チェック returned PASS / local deployment OK (report-only review). Source, installed web/project_id.js and live8188 HTTP200 payload SHA all equal d84877206cc1142dbfe7fce3f7e9c1b6edb8a22cae5ab117a1407f9435f6dea7. Runtime snapshot verified1 file. Browser hard-refresh and user-visible check remain; no browser reload, GPU, backend restart or publication performed. This supersedes deployment-pending wording below.
|
||||
- User-reported Full Video -> Review Each Chunk opened an old complete revision before generation. Reproduced with the real frontend harness (red.xml); mode selection now retains setup and the normal readiness summary without showing Retry/Restart. Existing Return to Review explicitly opens the saved result. Saved progress remains reusable; selecting Review does not mean starting a new Run.
|
||||
- Presentation token is transient, not serialized or a backend identity. A matching queued generation's new review revision releases it; same-revision history reads, delayed initial history before Queue, a previously queued result, or another Run's result do not take focus. Hidden old Retry/Finish is normalized to ordinary Continue at Queue while manual boundaries remain intact. Reload recovery, review completion, saved takes, Python and workflow bytes remain unchanged.
|
||||
- Focused90 PASS; final full1155 PASS in48.44s, CPU-only. Initial full had one old UI fixture failure: it injected a ready revision without Queue; fixture now models queued completion and keeps its prior expectations. Evidence: D:/Codex/_test_results/ComfyUI-H3-Continuum/v38-mode-settings-20260908. Completion report sent to fixed H3情報チェック; local deployment/readback pending that review. No commit/push/GPU or backend restart authorized/performed.
|
||||
|
||||
## Review UI hotfix — validated for user-authorized main publication (2026-09-08)
|
||||
|
||||
- User explicitly authorized a hotfix commit/push to existing origin/main for the confirmed Xarfai Review restart UI mismatch. Scope is frontend only: withdraw stale review actions after settings edits, preserve manual regeneration boundaries, add a non-destructive one-shot Start again from Chunk 1 button. Saved takes, sampler/transport/Audio/schema/workflow files and installed runtime remain unchanged.
|
||||
@@ -1729,3 +1743,19 @@ Static checks do not replace a real GPU generation. Record workflow, prompt, med
|
||||
- The tested seed did not reproduce Issue #13 sharpness ratchet: Laplacian decreased A `54.803→41.359` and B `54.803→40.399`. B showed greater saturation and skin-highlight growth and its 8-second PCM edge exceeded the pre-set A-relative screen on both channels. Visual/audio human review remains recommended, but there is no evidence here to replace Standard with Compatibility.
|
||||
- Current launch direction: keep Standard/Masked AV as default; do not promote Compatibility from this result; retain R6-A as Experimental/Default OFF pending active-gain multi-seed or reporter-exact validation. Issue #13 is not Solved. Production/runtime/public schema remain unchanged; no commit, push, tag or release was performed.
|
||||
- Evidence and report: `D:\Codex\_test_results\ComfyUI-H3-Continuum\v38-continuation-regression-final-gate-20260907\FINAL_ABC_REPORT_JA.md`.
|
||||
|
||||
## V3.8 Review Each Chunk live 3 x 5s acceptance PASS (2026-09-08)
|
||||
|
||||
- The remaining real-screen acceptance is now **PASS** on the user-managed `127.0.0.6:8188` backend. A single 3 x 5-second Review Each Chunk run advanced through `Chunk 1 is ready for review`, `Chunk 2 is ready for review`, then `Saved sequence is complete` only after Chunk 3. Chunk 1 and Chunk 2 each exposed `Use it and continue`, `Try this chunk again`, and `Use it and finish the rest`; the final state correctly removed no-op continuation controls.
|
||||
- The prior CPU-only frontend test had exercised an unsupported `beforeQueuePrompt` hook. ComfyUI frontend `1.49.6` actually runs widget `beforeQueued`, serializes through `serializeValue`, then emits `executed` and `execution_success`. `web/project_id.js` now uses that supported lifecycle to queue the transient Chunk 1 boundary without mutating visible/saved widgets and clears setup only for the exact node, Run name, setup token, and prompt identity.
|
||||
- Live prompts `8a9a2275-7f31-4e3b-bf7c-95747feefc2b`, `5427b850-0490-4b07-8243-77f737be7ba3`, and `ef38c575-faa8-45ea-8485-6ced1500298e` all completed successfully. Each reported exactly one new physical group: `1/3`, `2/3`, and `3/3` logical chunks available; Run Storage progression was `0 reused + 1 generated`, `1 + 1`, then `2 + 1`. Sampler node `312` was not returned as cached in any prompt; only upstream nodes reused ComfyUI cache.
|
||||
- Focused supported-lifecycle regression passed `1/1`; full CPU regression passed `1156/1156` in `50.60s`; JavaScript syntax passed. Source and installed runtime `web/project_id.js` are byte-identical at SHA-256 `78BA840BB4B57D21BC17AAB9F5CA3C89E3BC3C7AAE1A027BBD3FF54512717A53`.
|
||||
- Production Python, Sampling, transport, backend lifecycle, and workflow JSON were unchanged. The user performed every GPU Queue/Continue action; Codex did not start GPU work or restart/stop the backend. No commit, push, tag, release, or Registry publication was performed.
|
||||
|
||||
### Newly exposed Render History defect
|
||||
|
||||
- Opening Render History after the accepted run exposed a separate existing bug. The project index contains `76` group revisions across `59` sampling lineages, while the current canonical lineage contains only the three accepted revisions. The frontend presents all project revisions as selectable Takes; the backend correctly validates only the current contract lineage.
|
||||
- Selecting old Group 2 revisions `9db2a9287ef18796b770db00` or `f968bd1131c20912e207de0a` and queuing an action fails safely with `selected Take provenance is invalid: group revision parent is missing`. The message refers to absence from the current-lineage validation catalog, not deletion of the accepted canonical chain.
|
||||
- Repaired in `web/project_id.js`: the actionable catalog is now restricted to the canonical sampling lineage and revisions whose complete contiguous ancestry resolves inside that lineage. A stale hidden selection falls back to the corresponding canonical revision and resets its pending Take action. If settings differ from the reviewed result, Take application controls are disabled while read-only browsing remains available. Backend validation remains unchanged.
|
||||
- The history body is now a compact summary capped at 124 px. Its custom draw uses the reserved computed height even when the frontend supplies a single-row draw hint, eliminating the large blank panel and the one-line-only rendering observed live.
|
||||
- Mixed-lineage/orphan, selection fallback, compact rendering, and existing Review/Take regressions passed `59/59`; full CPU regression passed `1156/1156` in `52.09s`; JavaScript syntax and both manifests passed. Source/runtime JS SHA-256 is `549A8150BC926BF142758B1610E3730547D6ABCFBCDDB0B37ED8BAAAF86B38CB` after one-file deployment with Queue `0/0`. The current browser tab remains unreloaded because its title carries an unsaved marker; live visual confirmation requires saving or intentionally discarding that tab's changes, then reloading.
|
||||
|
||||
Reference in New Issue
Block a user