fix(ui): stabilize V3.8 review and render history

This commit is contained in:
ukr8b3g-cmyk
2026-09-08 17:28:18 +09:00
parent bd881e1bfa
commit 20be744b3f
9 changed files with 537 additions and 67 deletions
+29
View File
@@ -1802,3 +1802,32 @@ D:\Codex\_snapshots\ComfyUI-H3-Continuum\pre-rollback-after-00038-fail-20260821_
- Added browser-only generation-input snapshots (including connected inputs) to withdraw stale actions without granting backend reuse. Stale queued Review intent returns to normal Continue/Next compatibility checks. Added a transient, non-destructive Start again from Chunk 1 button using existing manual boundary/automatic nonce controls, consumed once after Queue. Preserved manual boundaries, saved takes, serialized widget order and all Python runtime contracts.
- Added real-JS lifecycle assertions for edits/undo, upstream prompt/media/bypass/reconnection, edits during generation, stale queue intent, direct manual regeneration, and one-shot restart. Focused frontend suite15 PASS after adapting extraction fixtures and simulating each completion's real queued settings. No GPU/model load/backend restart/workflow mutation/runtime deployment. Snapshots9 files verified. Final CPU checks, reviewer handoff and main push recorded in the task evidence folder and response.
- Final lifecycle hardening also preserves edits during a delayed initial history fetch and prevents a queued baseline from another Run Name being used. Focused61 PASS; full1155 PASS in46.62s; Registry105/source256 declared hashes PASS; all recorded CUDA exits false/blocked0. H3情報チェック returned PASS / PUSH TO MAIN OK after delayed delivery (user also explicitly permitted review waiver for this hotfix only). Reviewer noted updated_utc must remain a write-time revision signal; current history reads do not write it. Publication scope remains main source only, no new tag/Release/Registry assets; 15-second static/noise unresolved.
## 2026-09-08 — Local mode-selection setup repair
- Reproduced the user's Full -> Review pre-generation screen takeover in a real-JS test before editing runtime logic. Added a transient setup-selection token; old saved completion no longer hides the settings on this user action. Explicit Return to Review and newly queued review results can reopen review. Mode selection preserves saved progress and does not force a new run or erase takes. Queue from setup cannot inherit a hidden old Retry/Finish; manual regeneration remains supported.
- New cases cover complete/partial saved state, Storage Off/On, normal ready card, serialized values, history refresh before/after Queue, delayed first history, prior-flight completion, different Run Name, explicit return and subsequent review completion. Existing facade fixture now supplies Queue and completion rather than equating injected history with execution. Focused90 PASS; final full1155 PASS/48.44s; first red reproduction and first full1154/1 fixture failure preserved. Syntax and whitespace checks pass; package/source hash declarations refreshed without changing membership.
- Seven one-file source snapshots verified. Evidence: D:/Codex/_test_results/ComfyUI-H3-Continuum/v38-mode-settings-20260908. Fixed H3情報チェック received self-contained report; deployment pending review. User backend GET only at127.0.0.6:8188, queue0/0; no GPU, Queue, restart, workflow change or publication.
- Deployment completed after fixed reviewer returned PASS / local deployment OK (self-contained report review, not independent file inspection). Backed up installed JS1 file, deployed only web/project_id.js, verified source=runtime=live HTTP200 SHA d84877206cc1142dbfe7fce3f7e9c1b6edb8a22cae5ab117a1407f9435f6dea7. Live object_info lists H3ContinuumSamplerV38 from custom_nodes.ComfyUI-H3-Continuum. Browser visual confirmation remains for user hard refresh. No commit/push, browser reload, backend lifecycle or GPU execution.
## 2026-09-08 — Review boundary lifecycle correction, CPU Gate
- Reclassified the user's latest run from “Chunk 1 completed” to saved-history reuse: prompt/history showed zero new physical groups, all three logical chunks reused, and the previous canonical `complete` revision retained. This disproved the prior presentation-only completion claim.
- Corrected the first Queue after an explicit Full Video -> Review Each Chunk selection. If canonical saved review history exists, the API payload alone starts a non-destructive automatic-nonce branch at Chunk 1; serialized/visible settings and saved Takes are preserved. Sampler execution clears the transient setup state, reloads backend truth, and subsequent Continue actions inherit the branch for Chunk 2 and Chunk 3.
- Added exact backend and real-frontend `3 x 5s` lifecycle coverage. Focused Review/UI regressions passed `123`; full CPU regression passed `1156/1156` in `50.69s`. Registry/source Manifest hashes, JavaScript syntax and whitespace checks pass. Evidence: `D:\Codex\_test_results\ComfyUI-H3-Continuum\v38-review-boundary-20260908`. Fixed H3情報チェック returned `PASS / local runtime deploy OK`; its queued-identity note was applied by requiring the exact setup token and Run name before `onExecuted` may release setup. Actual UI/GPU acceptance is deliberately not claimed. No workflow, Production/Sampling, commit, push or release change.
## 2026-09-08 — Live Review Each Chunk lifecycle accepted
- Replaced reliance on the unsupported frontend `beforeQueuePrompt` path with the ComfyUI `1.49.6` widget lifecycle: `beforeQueued` -> `serializeValue` -> `executed` -> `execution_success`. Added the exact lifecycle regression and deployed only `web/project_id.js` after a one-file runtime snapshot.
- Validation before deployment: supported-lifecycle test `1 passed`; full guarded CPU suite `1156 passed` in `50.60s`; `node --check` PASS. Final source/runtime JS SHA-256: `78BA840BB4B57D21BC17AAB9F5CA3C89E3BC3C7AAE1A027BBD3FF54512717A53`.
- User-operated live 3 x 5s prompts completed as intended: Chunk 1 prompt `8a9a2275-7f31-4e3b-bf7c-95747feefc2b` generated physical group 1 and opened Chunk 1 review; Chunk 2 prompt `5427b850-0490-4b07-8243-77f737be7ba3` reused one/generated one and opened Chunk 2 review; Chunk 3 prompt `ef38c575-faa8-45ea-8485-6ced1500298e` reused two/generated one and showed complete. Sampler node `312` was not cached in any run.
- Final canonical run: `run_c05b0771405f40f78fbdd8055632e458`, revision `83cf80b0a4ff378b`, active group revisions `f3e4cf7f740ce4c7ad469238`, `a49003f2b27ceb1088b3f776`, `fad8dff7f8641f6e4b5dcc78`. Final preview was a continuous 15-second result.
- No Python Production/Sampling, workflow, backend lifecycle, commit, push, tag, release, or Registry change. All GPU Queue actions were performed by the user. Record snapshot: `D:\Codex\_snapshots\ComfyUI-H3-Continuum\before-v38-live-review-record-20260908_160004` (2 files).
### Render History diagnosis after live acceptance
- Read-only live inspection captured the exact failure: `RunStorageError: selected Take provenance is invalid: group revision parent is missing`. The displayed selections `9db2a9287ef18796b770db00` and `f968bd1131c20912e207de0a` belong to old sampling lineages.
- Current `project.json` contains 76 revisions across 59 lineages. The accepted canonical lineage `963eb7095602aef239570525bf999e77b71d8bfa2d5c5cf40f96c78a163fd72e` contains only `f3e4cf7f740ce4c7ad469238 -> a49003f2b27ceb1088b3f776 -> fad8dff7f8641f6e4b5dcc78`. Frontend `takeCatalog()` does not filter lineages, while backend `_validated_take_selection()` deliberately does.
- Classification: feature exists and the backend rejection was safe; frontend catalog eligibility and rendering were defective. Fixed by filtering to canonical-lineage, fully resolvable ancestry; stale selections automatically return to a canonical Take with `Automatic` action. History output is compact and draw-height independent.
- Focused Review/History regression `59 passed`; full CPU regression `1156 passed` in `52.09s`. Runtime deployment changed only `web/project_id.js` after Queue `0/0`; source/runtime SHA-256 match at `549A8150BC926BF142758B1610E3730547D6ABCFBCDDB0B37ED8BAAAF86B38CB`. Runtime snapshot: `D:\Codex\_snapshots\ComfyUI-H3-Continuum\before-v38-render-history-runtime-deploy-20260908_162700`.
- No Take was adopted and no generation was started by Codex. Live browser confirmation is pending reload because the existing ComfyUI tab is marked unsaved; it was not forcibly reloaded.