Release V3.5.1 conditioning bridge and reference audio
This commit is contained in:
+54
@@ -1,5 +1,24 @@
|
||||
# Work Log
|
||||
|
||||
## 2026-08-24 - V3.5.1 Issue #9 Conditioning Bridge CPU implementation
|
||||
|
||||
- Preserved all Issue #10 changes and created accepted pre-change snapshots: `pre-issue9-conditioning-bridge-source-accepted-20260824_190823` (460 files) and `pre-issue9-conditioning-bridge-runtime-w-accepted-20260824_190823` (337 files), excluding top-level `.git` and the pre-existing inaccessible `.pytest_cache`.
|
||||
- Added `H3ContinuumConditioningBridgeV35` as an Advanced MODEL + CONDITIONING interoperability node. It exposes one aligned pair per Continuum physical group, preserves complete CONDITIONING inner lists, updates target geometry, and explicitly leaves AV LATENT/noise/Audio Lock behavior to the external workflow.
|
||||
- Extracted shared physical-group preparation from Second Pass. The built-in path consumes each prepared group immediately, so its prior group-by-group sampling order and low-memory behavior remain intact; no V3.4 sampling, conditioning, Terminal Merge, Assembly, Seam, or Run Storage code was changed.
|
||||
- Added schema, registration, 37T + 77T Terminal Merge alignment, target geometry, context identity, and non-flattening regressions. Focused result: `33 passed`; full source pytest: `442 passed`; only the known `pynvml` FutureWarning remains.
|
||||
- Synchronized only `nodes.py`, `v3/second_pass.py`, `v3/conditioning_bridge_nodes.py`, and `tools/verify_runtime.py` to ComfyUI_W and verified per-file SHA-256 equality. Runtime verification passed package 3.5.0 registration, native PackedLayout, and Fixed 3x5 planning with the Bridge visible as a current node. The 163-entry distribution Manifest validates completely.
|
||||
- GPU Basic Guider / external sampler acceptance remains pending. Commit and push were not performed.
|
||||
|
||||
## 2026-08-24 - V3.5.1 Issue #10 Reference Audio CPU implementation
|
||||
|
||||
- Preserved the V3.4 public schema and added only internal V3.4 forwarding parameters plus two V3.5 optional sockets: `Reference Audio` and `Reference Audio VAE`.
|
||||
- Reused the existing Production/Core-compatible Reference Audio path without duplicate preparation or encoding. Standalone Reference Audio 1 is the only V3.5.1 scope; generated audio remains final unless the separate Driving Audio path is connected.
|
||||
- Added regressions for socket append-only compatibility, published V3.5 template routes, unused-VAE behavior, required VAE validation, Run Storage revision separation/restoration, and Reference Audio retention in normal and Terminal Merge refine-context groups.
|
||||
- Verified snapshots: `pre-v351-reference-audio-source-verified-ee7b993-20260824_171013` (457 files) and `pre-v351-reference-audio-runtime-w-verified-20260824_171013` (336 files), both with zero SHA-256 mismatch. Earlier standard-script attempts are incomplete because the pre-existing `.pytest_cache` ACL denies traversal.
|
||||
- Source focused regression `62 passed`; full pytest `439 passed`. ComfyUI_W received one preserved-tooltip Production merge plus three related tests; runtime focused result is `41 passed, 1 skipped`, syntax and runtime verifier PASS. The skip is only the public workflow-route test because `examples/workflows` is not installed in that runtime copy.
|
||||
- GPU tests 1-4 and required normal/Terminal long-form cases remain pending. Package version and public README remain V3.5.0.
|
||||
- User authorized publication. To avoid pushing the canonical branch's four private/local commits, copied only Production, three regression files, and Manifest into the clean isolated clone at public `origin/main`. Regenerated the 161-entry Manifest from public Git index blobs, correcting 36 pre-existing public-tree hash mismatches. Full isolated-clone pytest remained `439 passed`; commit `a704aa961fc2ba0c19aef6f2ecfdcb46fa9384b2` was pushed and remote-read back exactly.
|
||||
|
||||
## 2026-08-24 - V3.5 recommended template workflow
|
||||
|
||||
- Added `examples/workflows/MiniMax_H3_Continuum_V35.json` as the recommended V3.5 template while retaining every V3.4 template.
|
||||
@@ -342,3 +361,38 @@ D:\Codex\_snapshots\ComfyUI-H3-Continuum\pre-rollback-after-00038-fail-20260821_
|
||||
- Added the validated 9.49 GiB stress numbers to both READMEs: private memory 12.41 -> 2.91 GiB and USS 10.29 -> 0.80 GiB, with hash-identical RAM/Disk output. Explicitly documented that this is host-RAM/private-commitment reduction, not sampler VRAM reduction, and that Disk-backed can affect final assembly I/O rather than model sampling speed.
|
||||
- Updated Changelog, package information, package validation, V3.5 guide wording, and the 159-entry Manifest. Full canonical pytest is `430 passed`; every Manifest hash, `git diff --check`, and ComfyUI_W runtime verification pass. Nine changed public files/assets were synchronized to ComfyUI_W with per-file SHA-256 equality.
|
||||
- User explicitly authorized committing and pushing the complete V3.5.0 release state to `origin/main`.
|
||||
|
||||
## 2026-08-24 - V3.5.1 Last Queued Seed reuse frontend fix
|
||||
|
||||
- Preserved all existing Issue #9/#10 and earlier uncommitted work. The standard snapshot script was attempted first and failed only on the known ACL-inaccessible top-level `.pytest_cache`; accepted SHA-256-verified snapshots are `pre-v351-last-queued-seed-fix-source-accepted-20260824_210526` (467 files) and `pre-v351-last-queued-seed-fix-runtime-w-accepted-20260824_210526` (339 files), excluding `.git` and `.pytest_cache`, both with zero mismatch at source revision `ee7b9937dc9bda5b4e55b012e8e725b7afc5f3aa`.
|
||||
- Added session-only V3.5 sampler Seed state in `web/last_queued_seed.js`: `last_queued_seed`, `auto_updated_seed`, `previous_control_mode`, and `auto_update_pending`. `beforeQueuePrompt` captures the submitted Seed; `Randomize -> Fixed` restores it only when the displayed value still equals the exact ComfyUI automatic After Generate update. A manual Seed edit clears pending restoration. Linked/missing Seed inputs clear the capture.
|
||||
- No Workflow JSON state, new widget, backend change, cache manipulation, Run Storage relaxation, Sampling/Second Pass/Terminal Merge/Assembly/Seam change, V3.4 behavior change, Node ID change, or display-name change was introduced. Seed restoration only restores normal cache eligibility; an absent cache regenerates normally with the same Seed.
|
||||
- Added `tests/test_v351_last_queued_seed_frontend.py` with an actual Node.js module harness covering automatic restore, manual override, consecutive Randomize queues, Before Generate/no-update behavior, Fixed baseline, and linked Seed cancellation. Focused frontend regression is `5 passed`; JavaScript syntax passes; canonical full pytest is `445 passed` with only the known `pynvml` FutureWarning; source Manifest has 165 entries with zero missing or mismatched hashes; `git diff --check` passes.
|
||||
- Synchronized only `web/project_id.js` and new `web/last_queued_seed.js` to ComfyUI_W; both match source SHA-256. The runtime-specific Manifest received only the matching frontend entry updates; its pre-existing unrelated divergence from the canonical source Manifest was not normalized or overwritten. Runtime JavaScript syntax, compact-UI regression (`2 passed`), package registration, native PackedLayout, and Fixed 3x5 planning pass. Real `Randomize -> Fixed -> Second Pass ON` browser/cache acceptance remains pending; ComfyUI_W was not restarted or reloaded. Commit/push not performed.
|
||||
|
||||
## 2026-08-24 - V3.5.1 Hi-Res Fix Core canvas alignment
|
||||
|
||||
- Preserved all existing Issue #9/#10/Seed Fix working-tree changes. The standard snapshot script again encountered only the known top-level `.pytest_cache` ACL denial; accepted SHA-256-verified snapshots are `pre-v351-hires-core-alignment-source-accepted-20260824_213303` (470 files) and `pre-v351-hires-core-alignment-runtime-w-accepted-20260824_213303` (340 files), excluding `.git` and `.pytest_cache`, with zero mismatch at source revision `ee7b9937dc9bda5b4e55b012e8e725b7afc5f3aa`.
|
||||
- Diagnosed the GPU failure `shape '[1, 24, 1, 1, 21, 2, 21, 2]' is invalid for input of size 44376`: manual `576x576 * 1.2` used `round(36 * 1.2) = 43`, while Core H3 requires a 32-pixel canvas grid / even latent dimensions for its `2x2` spatial patchifier.
|
||||
- Added Core-derived manual target alignment in `v3/hires_fix_nodes.py`. The failing case now produces `704x704` / `44x44`; rectangular `1024x576 * 1.2` produces `1216x704` / `76x44`. No Sampling, Conditioning adaptation, Terminal Merge, Assembly, Seam, Run Storage, node schema, ID, or display name changed.
|
||||
- Added direct and integrated square/rectangular regressions. Focused Hi-Res/Second Pass result is `48 passed`; full source pytest is `448 passed` with only the known `pynvml` FutureWarning. An initial full run's 97 setup errors were solely the existing inaccessible global pytest temp root and disappeared with an explicit writable `--basetemp`.
|
||||
- Synchronized only `v3/hires_fix_nodes.py` to ComfyUI_W and verified exact SHA-256 equality. Runtime verifier passed package registration, native PackedLayout, and Fixed 3x5 planning. The running ComfyUI process was not restarted, so GPU re-acceptance remains pending after a deliberate restart. The attempted Seed cache run was not valid because its second prompt was queued before the first completed; logs show First Pass `20/20` ran again. Commit/push not performed.
|
||||
|
||||
## 2026-08-25 - V3.5.1 Reference Audio conditional UI and naming
|
||||
|
||||
- Preserved all existing Issue #9/#10/Seed/Hi-Res working-tree changes. The standard snapshot attempt failed only on the known ACL-inaccessible top-level `.pytest_cache`; accepted SHA-256-verified snapshots are `pre-v351-reference-audio-conditional-ui-source-accepted-20260824_230702-ee7b993` (470 files) and `pre-v351-reference-audio-conditional-ui-runtime-w-accepted-20260824_230702` (340 files), excluding `.git` and `.pytest_cache`, with zero mismatch.
|
||||
- Added `web/reference_audio_ui.js`. V3.5 Reference Audio sockets default to `Hidden` when unlinked, can be restored with `Show`, retain their original input positions, auto-open for connected saved workflows, and cannot be hidden while linked. No graph link is removed. The UI widget is attached only after Core graph configuration and removed from serialized Workflow widget values to avoid reload shifts.
|
||||
- Clarified only human-facing labels/tooltips: `Video Guide Frames`, `Driving Audio`, `Driving Audio VAE`, `Reference Audio (Optional)`, and `Reference Audio VAE (Optional)`. Backend input keys, ordering, types, Node IDs, conditioning paths, Sampling, Terminal Merge, Assembly, Seam, and Run Storage contracts are unchanged.
|
||||
- Live Chrome/ComfyUI testing on the already-running `127.0.0.6:8188` instance found and corrected two integration-specific issues that the initial mock did not expose: current Core keeps widget descriptors after the Reference Audio sockets in `node.inputs`, and UI injection before graph configuration can shift saved widget values. Final live acceptance passed `Hidden`, `Hidden -> Show -> Hidden`, original-position restoration, connected auto-`Show`, and linked hide protection. Temporary workflows were closed without saving; the template workflows were not modified.
|
||||
- Added/updated real JavaScript harness coverage for Core-style non-terminal inputs, disconnected `-1`, workflow serialization, labels, show/hide, link protection, callback chaining, and absent-input recovery. Focused validation is `20 passed`; canonical full pytest is `450 passed`; JavaScript syntax, `git diff --check`, and ComfyUI_W runtime verification pass with only the known `pynvml` FutureWarning.
|
||||
|
||||
## 2026-08-25 - V3.5.1 release documentation and naming
|
||||
|
||||
- Renamed the displayed video-guide inputs to `Video Guide Frames` and `Video Guide Size`; backend keys, input order, Node IDs, graph links, and saved-workflow compatibility remain unchanged.
|
||||
- Expanded English/Japanese README guidance for V3.5.1 Reference Audio, Conditioning Bridge, Last Queued Seed Reuse, and the distinct roles of still Reference Images, Video Guide Frames, Driving Audio, and Reference Audio.
|
||||
- Updated package version metadata, Changelog, package information, package validation, release tests, project state, and distribution Manifest for V3.5.1.
|
||||
- User explicitly authorized committing and pushing the complete V3.5.1 release state after validation. The supplied screenshots still showed the old display label, so no stale screenshot was added to the release documentation.
|
||||
- Replaced the initially supplied stale/shifted screenshots with three user-approved normal-state images showing `Video Guide Frames`, `Reference Audio Inputs: Hidden`, and `Show`; both README editions reference the same assets.
|
||||
- Final release checks: canonical ComfyUI_W-root pytest `450 passed` with only the known `pynvml` warning; JavaScript syntax and `git diff --check` pass; all 172 Manifest entries and README image/workflow references verify.
|
||||
- Added the user-supplied LBH + Conditioning Bridge workflow as a separate public connection example and a lightweight SVG flow chart to both README editions. The recommended template remains unchanged, and Core nodes retain their standard display titles.
|
||||
- Synchronized only the relevant implementation/tests to ComfyUI_W and verified per-file SHA-256 equality. No ComfyUI process was started or stopped. Commit/push not performed.
|
||||
|
||||
Reference in New Issue
Block a user