From e9b1294ccd08dfce972cd8e5a11703b3f616ee54 Mon Sep 17 00:00:00 2001 From: Miura Yoshiki Date: Mon, 12 Oct 2026 17:18:07 +0000 Subject: [PATCH] fix: reduce Issue #30 frontend overhead and release 3.9.2 --- AGENTS.md | 2 +- CHANGELOG.md | 7 ++ MANIFEST.sha256 | 32 +++--- PACKAGE_INFO_JA.txt | 29 ++++++ PACKAGE_VALIDATION.txt | 70 +++++++++++++ PROJECT_STATE.md | 10 +- README.md | 20 +++- README_JA.md | 20 +++- REGISTRY_MANIFEST.sha256 | 20 ++-- WORKLOG.md | 10 ++ docs/VALIDATION_JA.md | 31 ++++-- metadata.ini | 2 +- pyproject.toml | 2 +- tests/frontend_issue30_ui.cjs | 131 ++++++++++++++++++++++++ tests/frontend_reference_images_v39.cjs | 81 ++++++++++++++- tests/test_issue30_frontend.py | 54 ++++++++++ tests/test_release_metadata.py | 2 +- tests/test_v217_stable_facade.py | 2 +- version.py | 2 +- web/project_id.js | 3 +- web/reference_images_v39.js | 9 +- 21 files changed, 485 insertions(+), 54 deletions(-) create mode 100644 tests/frontend_issue30_ui.cjs create mode 100644 tests/test_issue30_frontend.py diff --git a/AGENTS.md b/AGENTS.md index a708075..fd2aab2 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -2,7 +2,7 @@ ## Scope -MiniMax H3 Continuum for ComfyUI. Package 3.9.1 provides the V3.9 Sampler and Reference Images helper, while retaining the separate V3.8X2 workflow. Source publication does not imply a GitHub Release or Registry package publication. +MiniMax H3 Continuum for ComfyUI. Package 3.9.2 provides the V3.9 Sampler and Reference Images helper, while retaining the separate V3.8X2 workflow. Source publication does not imply a GitHub Release or Registry package publication. Sampling Contract v6 and Graph Contract v4 apply to new generation. Keep original v5 history readable, without reusing its Takes in v6 generation or rewriting stored manifests. Public node IDs, socket/widget order, official workflows, Run Storage v3 and State/Session formats remain unchanged. diff --git a/CHANGELOG.md b/CHANGELOG.md index 9dd0218..710f3b8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,12 @@ # Changelog +## 3.9.2 — Issue #30 frontend hotfix (2026-10-13) + +- Skip upstream Review settings snapshots when no comparison baseline exists. Keep drawing-time edit detection and synchronous Queue/Take checks for reviewed settings. +- Notify connected Samplers once per Reference selection through the native callback, and skip `setSize()` when node dimensions are unchanged. Native assignment values still update synchronously; saved workflow and generation contracts are unchanged. +- Track the separate Reference Plan Inspector refresh failure after repeated Sampler configuration as an expected regression failure. No delayed update timer or new animation-frame scheduling is introduced. +- Bump package metadata to 3.9.2 while keeping V3.9 node IDs and existing generation/storage contracts. Native values and Review safety guards remain synchronous. Mobile freeze resolution is unconfirmed; Reference table rebuilding and snapshots with a Review baseline remain. + ## 3.9.1 — stability fixes (2026-10-04) - Preserve audio-only and mixed Second Pass keyframes while spatially adapting only video. diff --git a/MANIFEST.sha256 b/MANIFEST.sha256 index e8f828b..f555e25 100644 --- a/MANIFEST.sha256 +++ b/MANIFEST.sha256 @@ -4,7 +4,7 @@ dca65fb1393e67f59c6f81f9411e3e745eb8f1097e9a2adf7ffc6f4e3901ca9f __init__.py 8296f0afc7be47171e439c02fb2988cfeb0df904acbe3fc4f507f426d709157e .github/workflows/tests.yml a28c4c592d56c57e0967f0adce5655313b942b8cc04f77766c0db1bec96c13e0 .gitignore 3e7a1ec3380be2a222c8a3e9b8a6bb184d3a760478957f48186438f15235bdba branch_provenance.py -3a9cb2ac82d6a59e929017904d6a282fa2163368721044dd9c00c81627da95c8 CHANGELOG.md +2839ac42889341b018bc6013cfe7e5cf4cca81f3b80fae0620ac30612a5918e5 CHANGELOG.md c1ed3a0342730450958fb62fd21854a876991f3a4aefb24e5383b0c73cd2312d compatibility.py 4d62508f900af9f93ec320afb900c27cc9a300d1e0c0a94714258498c5ede5fc conditioning.py 294251c40b1be2e296c5e5f627b68091d087bdb39179e3a0c3cebd2ee8a344f5 constants.py @@ -89,7 +89,7 @@ ca9f1aecd1032f0f0b237948c7fc1e4e693440dff35f5f17fd5e6d5ca4dab7f9 docs/V38_BEGIN 717577efdec5e61600504b77bc2a099ef022c4fe2333e936c3310c7182d8f2a0 docs/V38_OPEN_INTEGRATION_CONTRACT.md 3496636f645b39336fd95a4f21a562810c56f8e1d92fa6eeb1e4b0786ad11b37 docs/V38_RELEASE_AND_MIGRATION.md 4d17d74107e78404b190fec9494b443249e5aff4f58670c50d54dfdfb064334b docs/V39_REFERENCE_INLINE.md -e558a7d2282873437ed6f704eb9991ff5fb5f3c2b60d9f9891058efd2824d8a4 docs/VALIDATION_JA.md +be4440167361f33659f1f34cc81653989412ab0c5509966d44753edb59816c05 docs/VALIDATION_JA.md 3fec541a675c1e4e5e287cc8e498036001f34f7a62460321e16f9ba27b5e4c18 docs/VALIDATION_RESULTS.md a8c56379abe23b98c8ceed6ea5e60a02ecc3c6d9636232d7371615f4eb306e81 driving_audio.py 6771c9905d35666121c4892d2ec26202505f96d244ce814ad9a87a02878952cd examples/H3_CONTINUUM_V1_WIRING.md @@ -127,21 +127,21 @@ bf0556b076dbaca67c3405a7d86c333ca7fdf3d4381529b0a9edc906519943e9 guide_timeline 139546ec1ff459945aa89b50f74b5ee69f62a0e07bbddfcae06936091a409a83 layout_adapter.py c44abbd789091bbead01250dbd5453e60539d2665c69f162335fdbd2936019c2 LICENSE d3e213005670e94dee33a240349a4d245cf9a3b6602099f11ed30cf5a32e2c21 media.py -ad0835f8fb6d171d8ff8d7295fb48291abc93ef02fd46a2e283265c15b93366a metadata.ini +a4b2b73c50ad05e4d6711e5db4a58c12cb98177ced27d29b2fb4e247761c5c01 metadata.ini fd23c7f32810788aaaf1709c4959c40ec72303aecc6f6afa5fa68d824cca97a8 minimax-h3-continuum-dance-director.zip d7e613e2cc24110213b477bdd1d390234a41f2af3b1ed006a809066d71d658eb model_patch.py ecb65a5dbf9e1683c5a3cadd82daaea3a90a2b776f6ebabfbe8b07aa93177422 nodes.py -1568dc8a5b5d8678f69846252ea10dbd33f7226f533c7767384516bdb8004fab PACKAGE_INFO_JA.txt -e98b150a8587fd67df53c0962ea86232eede355450c621f20fbb6d7ec9018ac7 PACKAGE_VALIDATION.txt +cd187770a30eba87f576da9baa7de8fb53ebfc7e739e8412e1558bf7ed161660 PACKAGE_INFO_JA.txt +3b729a12c3b89f88055267ef6a14e9df71752fa2d0c4d586d0e8b96a05d3ed7c PACKAGE_VALIDATION.txt b470819f16fc179654dc1600721a63f0a5a14e777f4c004d574b499da6886ba5 public_api.py -1047d05b0aedc405e3a36ee571a8939111d69bb5565e09a3e1caa3c40bf33170 pyproject.toml +ffbe4240d104d360c280a5d4743432520c265f1021c5f4668a977b22a6a8bddb pyproject.toml 94fdc2d545b2d4077a4d70229fd22ba3ccac21d49d1097d2873f76d04e9a3c7a pytest.ini -0b7cd2a93c820955d1dc22f5a22d83ee25bf43bac67900b223fcddc6971f4cef README_JA.md -2cbe9848c0d3e477928c054c994e56adad706f3e8c2b8561b6ace17741faf770 README.md +65daf6eb0585c4850a0d306a00b801f9f356583f25e23be327f2dc7e98d7cdbd README_JA.md +9f60c0074efa406611a7433489d87f8b0e7bfbb9e1649b5bf14232ce9dc98641 README.md 9539f5cb9fb695841073fa58d9246d5a7410bc372f6cd340378185004dfaf978 reference_audio.py 5cb9bfd6810d3a93a637451980a4cc5c1436e5b84cfd1c7a111cd192e876351b reference_video.py caa572ea65dafc86850db99f52433d360ac9c4ab36b854292a3dccd5ba32dc76 reference.py -ad043fb5b30e68c2c330beb9689b06d56286f5e696b522f7b8f95617b7869058 REGISTRY_MANIFEST.sha256 +8f59c2eb987b5a886d4c3a2031f0def8794a99ba564ac31e18245db8f5c3a423 REGISTRY_MANIFEST.sha256 467edb2c188d024c2392aafe7423b3f835e16b10f570da76e2f7dda8a962c1c5 requirements.txt 1845cbf7ba4d3b35afd087a15f5a4d92dc73d4858e61982f8ccf431a836a22b1 run_storage.py 6056de6c0a5322a8a51ba5a114538dca2ef67788cd1afba10fedd483b95f6afa state_io.py @@ -157,7 +157,7 @@ a41a4de12e6fe5690845f9f0795fa82c4907f0afe2551034fa2a4c95617ac39c tests/decode_c db08ce77cc5c5835f2403d4d589394090fa5d25ff3b1840312b2808e1bc203b7 tests/fixtures/v38_a3c_selective_refine_saved_workflow.json 606b3985f2b644fac40c84de3e08d1453e87a988acca51ce9595516a7c60a577 tests/frontend_decode_cache_helper.mjs 868c613654467c2c739e07de5dd9b4679b36f98cd96d631d91e1d4afe5698cf5 tests/frontend_external_int_size.cjs -da45ac4b9422f04a6867ff4cff4b12cf1dff88422522b8010a960b5ecfce046a tests/frontend_reference_images_v39.cjs +a328953818ef9bf43e411331d2289ccf98a7bdd31dd9e1c1af449b4a1b632c9d tests/frontend_reference_images_v39.cjs 751f38be4351d459145beb3a533530e0c667552fe148de2f732efbb04494b660 tests/frontend_review_queue.cjs 36f74c03a40c4b62b90eede070d976bcd1b7f0ea828983d1e61a6cb6d80a0ea8 tests/helpers/r5_process_crash_worker.py 706029af8c8d979b2b700f5bc2b96a3064fe7c728f487698d9f079abb02e9409 tests/terminal_merge_diagnostics.py @@ -193,7 +193,7 @@ c2560cbafc5962bce5f063e262cf6a173dd8df18f7b58035ec326f616617d61c tests/test_p25 2d16f6de7bcaf1f92718d3719654a746438f6218bba8d25b3632c318a1ab9c98 tests/test_packed_layout_preflight.py 1ae0369943ba2fb13f21ad0cf56ee58621ba09bf20174379595e157a1775c7fd tests/test_public_api.py 892d3e3e022a527652dd995508c8bbb650c370caf9ee66fa3eb1f7fd288bba38 tests/test_public_workflow_integrity.py -6e31f0891e592138a911c4ffffda9ebe5b5db6350318c4d1bfdf3c5e1f149678 tests/test_release_metadata.py +1be35d57f4550de029cb3c8a06378183982dacda7736681e95f0d3f4c29cf8bf tests/test_release_metadata.py 5f6caf1814052798f20571ebb863c098bec23d8f2e091fc1f30ce1ef9c58675a tests/test_review_identity_lifecycle.py 5f7d3e01bc78fa076ecb17f8532b6d3f3137545da4028032ad6769407d80be07 tests/test_review_provenance_reroll.py d5e255a5fdd06ea18e70f4077f855ed2f02664f91caf79b66bfbdf7df44ad07b tests/test_review_rehydration.py @@ -217,7 +217,7 @@ b42bcc0983147462d96c6b71cc4a38e846995dafa6eebefc3ae0d9bb36caf359 tests/test_v2_ 0b5b20a8318862d167f135720e0489b8d4f93406d67c6646e052e35b03dcb876 tests/test_v2_session.py b5c320279fd38d2038e39951a3d016aa9b80741523d2816e01ceda1bdecb71b8 tests/test_v2_terminal_merge.py e22486ac62c53132c275614e4e161c78e6dce09dd0d1a7cf64f641a3b7052b99 tests/test_v2_widget_migration.py -7b4edd7d09e382926f94f391f5a58fdee4204affbf6a72c225313ea0a5c9d9f6 tests/test_v217_stable_facade.py +f8c363b1700e6f84f612aa3478e14fdbdfb881107dfeabb81a124e5413f080c2 tests/test_v217_stable_facade.py 473abac48a57aa5f297c6e141a94de17ddcb9424a8744bae1c46e6a6a734a0ab tests/test_v3_hardening.py 9242f74663ccb04020ad2fb1199990c84433c9b4c5cf0560e93416c7b15e1913 tests/test_v3_physical_decode_groups.py 35b26c8cade7acb2eec35375d7dfa9a4a112f67a5cec6a842d61c69039de0d84 tests/test_v3_video_seam.py @@ -400,7 +400,7 @@ d0a004aa3030c8adaa5ea788f9acc758fcb4a556f203f9a3f63fa4e4b5772063 v3/sampling_en 26b13614ba0a5fd8b192a106c9503b2f4b6fe7f9268a0fcb0f544979a49cab34 v3/video_adapter_nodes.py 4178dcfa442abdb06ce276e05bd7bcbaa6da28469ba5e57d3da3c663de4e4a9d v3/video_seam_v35.py 2f07ace1462644f0bee553827b3571535de4d0c2d9ef847bd9e0ca73a4eed5cb v3/video_seam.py -f1c9df5eb9f6c75bd0e505fb84731951fcd9ef1ab5d7f93a0c72f05488fa05fb version.py +76db0e3f2bba3e72050c6e35c47a1460fc5a74203d82aa63118b3f4e06ae4ac3 version.py b935ad3bb729948bb3890ce967b0ecbef737a5e51ddfc47a0060fc20aa78dcda video_reference_modes.py 685df8e0fa23e3663ab31da1e4470cd19bdaa0dc16362cb606e874d9d6153c2c web/decode_cache_helper.js fefafd4550511d80bd85ade46a0476f0cf3de13ddb94a908dff6b175f2a0e199 web/easy_bypass_toggle.js @@ -408,10 +408,10 @@ fefafd4550511d80bd85ade46a0476f0cf3de13ddb94a908dff6b175f2a0e199 web/easy_bypas 9db0aa94f634578a962d5db49e5c70356040a59df968e3a2e531b327a623081f web/easy_load_image.js 35090816ba7470a7255eb85d003b7e79f8a0065982dacf98a18f41c8ebff655d web/easy_load_video.js 0c68d13a1f8beb7431a32b471f8b0612c42fcc4bf72dd97611a025d158008662 web/easy_v38.js -fbceb922aa3a5ef54886f0ca4c1a07c516ec9fadca04080049ef11f15d584668 web/project_id.js +90bef8b7628106fffa95ac1e27e345fa3ccc7203bd2f608497f46b751f9bb850 web/project_id.js ae59273f163a116ece418957c557c4fd8c3285e3c60814679b9361d2e6e6fa02 web/reference_audio_ui.js 46c9f75c9462bf26300332448f4431cca801f38964ca0a49bc2c50a88a7cc40f web/reference_image_ui.js -e9d7753f313ebbe3d13e477f5b4e4767a735b0619b52ba54bcc5218f3eb7eb7c web/reference_images_v39.js +beea70f6e25e1366aba5e2689c31733478472f207dc50cad1562cd877152e4f9 web/reference_images_v39.js bf41bf08dd0504eb753fa5781e6c2b8c1285758ad4bb7309975bb9231d5f8e41 web/video_reference_mode_ui.js 2bcf455b4ece8b1861e327f6f9f8a79170e7c77470155aacada52e18438543dd write-h3-v39-reference-prompts.zip a9f7b67bd65a9beda622aa5fdc5f8a2ecae1b58b18690d91fb0107a16a3e384e write-h3-v39-reference-prompts/references/simple-3x5.txt @@ -427,3 +427,5 @@ b27004f82a3c551926e7e8f5bfa140af1eb2a1cf39ee5660f1d5b2495cf474ed tests/test_v39 d2e59eae0a724626b0a4e361921643dd31cb3612ae1f0d1b8b355c9d42c06174 tests/test_v39_stability_r3.py 072091309b35ff5c204c49ed478d9cdcc39d316df15a6209f687b33d13bbf790 tests/test_v39_stability_r4_r5.py 319258798ca198312cf684f369990924657d1af168a148ad34303af31c06a350 tests/test_v39_review_refine_scope.py +8d0ccf5711e1be0bf63b4e02fecb0b37cd88979894d27b89337cda4a6d1c4ec5 tests/frontend_issue30_ui.cjs +d6b5b969a0c02f1b282da990db3e503e0768747cfac8a4edd32cf8677550e024 tests/test_issue30_frontend.py diff --git a/PACKAGE_INFO_JA.txt b/PACKAGE_INFO_JA.txt index dacc451..0d1f4c4 100644 --- a/PACKAGE_INFO_JA.txt +++ b/PACKAGE_INFO_JA.txt @@ -1,3 +1,32 @@ +ComfyUI-H3-Continuum 3.9.2 / Issue #30 Frontend hotfix +パッケージmetadata: 3.9.2(2026-10-13)。公開登録は12ノード。 + +今回の修正: +- Review比較基準なしの上流snapshotを省略。 +- Reference選択時のSampler通知を1回へ整理。native値と元callbackを維持。 +- ノード全体の目標寸法と実寸が同じならsetSizeを省略。 +- 基準ありの監視、Take/Queue時の最新確認、V3.9の公開仕様・保存契約を維持。 + +検証: +Frontend修正の実Core CPUは1703成功/2スキップ/2期待失敗。 +期待失敗は独立したInspector再configure問題の2条件です。 +既存Review Queue JS 62条件と外部INT JS 22条件、Coreの登録・計画確認は成功。 +隔離Chromiumで基準なしsnapshotと通知・同寸法resizeの削減を確認しました。 +公開候補の最終試験と実ComfyUI画面の結果はPACKAGE_VALIDATION.txtを参照。 +モバイルのフリーズ解消は未確認。DOM再構築・基準ありReview走査とInspector +既知問題は残ります。今回の新規GPU生成はなく、以前のGPU結果とは区別します。 + +更新: +ブラウザーを強制再読込してください。表示するpackage番号も更新する場合は +通常の手順でComfyUIを再起動してください。引き続きV3.9ノードを使用します。 +3.9.1のRun/Takeを今回のUI修正のために移行する必要はありません。 +公式Workflow JSON/ZIPのbytesを保持。Experimental LoRA/V4.0は含みません。 +固定版はGitHub Releasesを参照し、Registry公開は別作業です。 + +====================================================================== +履歴:3.9.1安定化修正の記録(以下の件数・GPU結果は当時のもの) +====================================================================== + ComfyUI-H3-Continuum 3.9.1 / V3.9安定化修正・V3.8X2併存 パッケージmetadata: 3.9.1(2026-10-04) diff --git a/PACKAGE_VALIDATION.txt b/PACKAGE_VALIDATION.txt index 63386ca..b6fffbe 100644 --- a/PACKAGE_VALIDATION.txt +++ b/PACKAGE_VALIDATION.txt @@ -1,3 +1,73 @@ +ComfyUI-H3-Continuum 3.9.2 / Issue #30 frontend hotfix - 2026-10-13 + +Package metadata: 3.9.2. Public registration: twelve nodes. Continue using +V3.9 nodes; V3.8X2 remains a separate workflow. + +Repair scope +- Skip upstream Review settings snapshots only without a comparison baseline. +- Notify each connected Sampler once per Reference selection, preserving + synchronous native values and the original widget callback. +- Skip setSize when the complete Reference node target dimensions equal + its actual dimensions. Height-style same-value assignment remains. +- Retain Review monitoring with a baseline and fresh Take/Queue checks. +- Keep Sampling Contract v6 / Graph Contract v4, Run Storage v3, public IDs, + widget/socket order and official workflow bytes. + +Validation scopes (do not add counts from different environments) +- Frontend repair with real Core, CPU: 1703 passed / 2 skipped / 2 xfailed. + The two explicit expected failures track one independent Inspector bug: + stale verified text after 2 or 100 Sampler configure passes. +- Skips: Windows private-commit metric and absent historical V3.5 workflow. +- Existing Review Queue JavaScript: 62/62 passed; external INT: 22/22 passed. +- Offline native PackedLayout, Fixed 3x5s planning and twelve-node registration + passed. CUDA initialization attempts: zero. +- Isolated desktop Chromium, actual frontend JS/DOM with graph/API fixtures: + 600 baseline-free draw callbacks: snapshots 600 -> 0. With a baseline, + snapshots remain 600. Thirty connected checks: notifications 60 -> 30, + unchanged-dimension setSize calls 30 -> 0. Table rebuilding remains. +- Release-candidate CPU/metadata and real-ComfyUI browser results are recorded + below after final preparation. Standalone GitHub Actions is a separate gate. + +Remaining limits +Mobile freeze resolution is unconfirmed. Review snapshots with a baseline, +Reference table rebuilding and the independent Inspector display bug remain. +No new GPU generation was run for this frontend hotfix. Earlier 3.9.1 GPU +results are historical evidence, not 3.9.2 GPU validation. Full official +workflow generation and all accelerators remain outside this repair gate. + +Updating and publication +Hard-refresh the browser after updating JavaScript. Restart ComfyUI normally +if the displayed package version also needs refreshing. 3.9.1 Runs/Takes +require no migration for this UI hotfix. Users upgrading from pre-v6 code +must still follow the older v5 history instructions below. +GitHub Release/tag and Registry publication are distinct; old tags are kept. +Current publication status is listed in GitHub Releases. Registry publication +is not part of this hotfix task. + +Final 3.9.2 candidate validation - 2026-10-13 +- Real-Core CPU regression: 1703 passed / 2 skipped / 2 xfailed; no unexpected + failures; zero CUDA initialization attempts. The independent Inspector + reconfigure bug remains explicitly tracked. +- Actual ComfyUI 0.38.0 / frontend 1.53.6 / Chromium 151.0.7922.173 smoke: + physical checkbox interactions, Prompt/link/Bypass edit detection and + restoration, Chunks shrink/restore, pan/zoom, native assignment graph + serialization and app.loadGraphData reload passed. +- Before/after frontend JS responses used the actual Core/frontend/LiteGraph + with additive instrumentation. Baseline-free 600 draw callbacks: 600 -> 0 + snapshots. With a baseline: 600 -> 600. One checkbox: 2 -> 1 Sampler + notifications; same-dimension resize: 1 -> 0. +- Scope: desktop headless browser, synthetic connected image/string nodes, + model-free CPU server and graph reload. UI file-save, real stored Take + adoption, mobile hardware and full official workflow acceptance remain + separate. No POST /prompt, generation or GPU execution occurred. +- GitHub Actions status must be read from the published candidate commit; + the real-Core count above is not a claim that Core cases ran in standalone CI. + +====================================================================== +Historical 3.9.1 stability validation - 2026-10-04 +The original record below describes that package, its tests and publication. +====================================================================== + ComfyUI-H3-Continuum 3.9.1 / V3.9 stability validation - 2026-10-04 Current package metadata: 3.9.1. Public registration: twelve nodes. diff --git a/PROJECT_STATE.md b/PROJECT_STATE.md index 04aa52e..d954731 100644 --- a/PROJECT_STATE.md +++ b/PROJECT_STATE.md @@ -1,8 +1,14 @@ # Public source status -Updated: 2026-10-04 (Japan time). +Updated: 2026-10-13 (Japan time). -## Package 3.9.1 +## Package 3.9.2 — Issue #30 frontend hotfix + +This package includes three minimal frontend changes: skip Review snapshots without a comparison baseline, notify connected Samplers once per Reference selection, and skip unchanged node dimensions when resizing. Review baseline monitoring, synchronous Take/Queue checks and generation/storage contracts are retained; package metadata is 3.9.2. + +CPU/JavaScript regression checks passed 1,703 cases, with 2 skips and 2 explicit expected failures for the separate Inspector reconfigure bug. Offline twelve-node/runtime checks, isolated Chromium checks and the actual Core/frontend/LiteGraph desktop smoke passed without GPU generation. The live smoke covers native assignment graph serialization/reload and upstream edit/restore using synthetic nodes; UI file-save and stored-Take acceptance remain separate. DOM rebuilds remain; real ComfyUI browser save/reload, mobile freeze resolution and full workflow acceptance are still pending. No delayed update timer is added. See GitHub Releases for the published version; Registry publication is separate. + +## Previous package 3.9.1 — generation stability history This patch stabilizes V3.9 generation and Review without adding LoRA Plan or V4.0. Public V3.9 node IDs and official workflows remain unchanged. V3.8X2 stays available as a separate workflow; historical releases and tags remain available. diff --git a/README.md b/README.md index 10ead04..8fe221b 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,18 @@ -# ComfyUI-H3-Continuum 3.9.1 — V3.9 +# ComfyUI-H3-Continuum 3.9.2 — V3.9 + +## 3.9.2 — Issue #30 frontend hotfix (2026-10-13) + +This hotfix reduces unnecessary Review and Reference Images UI work: + +- Skip upstream Review settings snapshots when no comparison baseline exists. +- Notify connected Samplers once per Reference selection, preserving immediate native values and the original widget callback. +- Skip Reference node resizing when its target dimensions already match its actual dimensions. + +Review monitoring with a baseline and fresh Take/Queue checks remain in place. Sampling, saved Runs/Takes, public node IDs and official workflow bytes are unchanged. Keep using the V3.9 nodes. + +The frontend repair passed **1,703 CPU/JavaScript regression tests, 2 skipped**, with **2 explicit expected failures** for the independent Reference Plan Inspector bug after repeated Sampler configuration. Offline Core registration/planning and isolated Chromium checks passed. Real ComfyUI browser checks for this package are recorded in [PACKAGE_VALIDATION.txt](PACKAGE_VALIDATION.txt); mobile freeze resolution is unconfirmed. Reference table rebuilding and Review snapshots with a baseline remain. No new GPU generation is part of this hotfix's validation. + +After updating, **hard-refresh the browser (Ctrl+F5)** to load the JavaScript. Restart ComfyUI normally to update the displayed package version. A 3.9.1 Run/Take does not require migration for this UI hotfix. Versioned downloads are listed in [GitHub Releases](https://github.com/ukr8b3g-cmyk/ComfyUI-H3-Continuum/releases); Registry publication is separate. ## 3.9.1 — what changed (2026-10-04) @@ -75,9 +89,9 @@ The selected V3.9 template has 32 nodes. Image loaders 1–6 are wired to the ne In the helper, `All chunks` uses connected images throughout; `Per chunk` provides an image-by-chunk table. The template starts in `Per chunk` with all assignments off: after enabling a loader, tick the chunks that should use it. Slot numbers never shift: Image 1 is `@R1` and Image 9 is `@R9`, even when intervening slots are empty. In Sequence Prompt, describe the action for each chunk and use `@R` tags only for active References; their actual `` numbers are resolved per group. Unused tags warn without stopping generation. Start with short chunks and pre-resized images: source images may consume RAM before the Sampler's Reference Image Size setting applies. -V3.9.1 is the current source version on `main`. Download versioned source from [GitHub Releases](https://github.com/ukr8b3g-cmyk/ComfyUI-H3-Continuum/releases); ComfyUI Registry publication is separate. Historical Releases and tags remain available. Configured 1024×1024 Reference-only GPU/API runs succeeded, but the unchanged default template and browser save/reload remain separate acceptance gates. For a reproducible older environment, use the matching historical Release/tag and workflow; the retained V3.8 Sampler on current `main` specifically supports V3.8X2 workflows. +V3.9.2 is the current source version on `main`. Download versioned source from [GitHub Releases](https://github.com/ukr8b3g-cmyk/ComfyUI-H3-Continuum/releases); ComfyUI Registry publication is separate. Historical Releases and tags remain available. Configured 1024×1024 Reference-only GPU/API runs succeeded, but the unchanged default template and browser save/reload remain separate acceptance gates. For a reproducible older environment, use the matching historical Release/tag and workflow; the retained V3.8 Sampler on current `main` specifically supports V3.8X2 workflows. -`pyproject.toml` declares ComfyUI `>=0.32.0`; earlier real-generation/GPU validation used ComfyUI `0.34.2`, and the scoped Fixed cache comparison above used `0.38.0`. The minimum declaration does not establish V3.9 runtime acceptance on 0.32.0. The latest recorded Windows CPU run is `1696 passed / 1 skipped / 0 failed`; the earlier separate Linux rerun report records `1534 passed / 3 skipped / 0 failed` and does not include the new cache or external INT tests. Neither replaces browser save/reload or GPU acceptance for the unchanged official template. +`pyproject.toml` declares ComfyUI `>=0.32.0`; earlier real-generation/GPU validation used ComfyUI `0.34.2`, and the scoped Fixed cache comparison above used `0.38.0`. The minimum declaration does not establish V3.9 runtime acceptance on 0.32.0. The previous Windows CPU run is `1696 passed / 1 skipped / 0 failed`; the earlier separate Linux rerun report records `1534 passed / 3 skipped / 0 failed` and does not include the new cache or external INT tests. Neither replaces browser save/reload or GPU acceptance for the unchanged official template. ## V3.9 Reference Images diff --git a/README_JA.md b/README_JA.md index e96eaf6..cf17616 100644 --- a/README_JA.md +++ b/README_JA.md @@ -1,4 +1,18 @@ -# ComfyUI-H3-Continuum 3.9.1 — V3.9 +# ComfyUI-H3-Continuum 3.9.2 — V3.9 + +## 3.9.2 — Issue #30 Frontend hotfix(2026-10-13) + +ReviewとReference Imagesの不要なUI処理を削減します。 + +- Review比較基準がない場合、上流設定snapshotの作成を省略。 +- Reference選択時のSampler通知を1回へ整理。native値の即時更新と元widget callbackを維持。 +- Referenceノードの目標寸法と実寸が同じ場合、不要なサイズ変更を省略。 + +比較基準がある場合の監視と、Take/Queue時の最新設定確認を維持します。Sampling、保存済みRun/Take、公開Node ID、公式Workflowのbytesは変更しません。引き続きV3.9ノードを使用してください。 + +Frontend修正で**CPU/JavaScript回帰1703件成功・2件スキップ**、独立したInspector再configure問題の**2条件を期待失敗として記録**しました。Coreのオフライン登録・計画確認と隔離Chromium検証も通過しています。このパッケージの実ComfyUIブラウザー確認は[PACKAGE_VALIDATION.txt](PACKAGE_VALIDATION.txt)に記録します。モバイルでのフリーズ解消は未確認です。Reference表の再構築と、比較基準がある場合のReview走査は残ります。今回のhotfixで新たなGPU生成は行っていません。 + +更新後は**ブラウザーを強制再読込(Ctrl+F5)**してください。表示するパッケージ番号も更新する場合は、通常の手順でComfyUIを再起動してください。3.9.1のRun/Takeは、このUI修正のために移行する必要はありません。固定版は[GitHub Releases](https://github.com/ukr8b3g-cmyk/ComfyUI-H3-Continuum/releases)を参照してください。Registry公開は別作業です。 ## 3.9.1で変わった点(2026-10-04) @@ -75,9 +89,9 @@ ComfyUIの **Templates → ComfyUI-H3-Continuum** には、今回選んだ[V3.9 ヘルパーの `All chunks` は接続画像を全チャンクに、`Per chunk` は画像×チャンクの表で指定します。このテンプレートは`Per chunk`で全チェックOFFから始まるため、Loaderを有効にした後、使用したいチャンクにもチェックしてください。空欄があっても番号はずれず、Image 1は常に`@R1`、Image 9は`@R9`です。Sequence Promptにはチャンクごとの動作を短く書き、そのチャンクで使う画像の`@R`タグを付けます。内部の``番号はgroupごとに自動変換されます。使わないタグは警告しますが生成を止めません。まず短いチャンクと縮小済み画像で試してください。入力元画像はSamplerのReference Image Size設定より前にRAMを使うことがあります。 -V3.9.1は`main`の現行ソースです。バージョンを固定したソースは[GitHub Releases](https://github.com/ukr8b3g-cmyk/ComfyUI-H3-Continuum/releases)から取得してください。ComfyUI Registryへの公開は別の作業です。過去のReleaseとtagも残します。設定済み1024×1024のReference-only GPU/APIテストは通っていますが、無改変の公式テンプレート初期設定とブラウザー保存・再読込は別の受入項目です。古い環境を厳密に再現するには対応する過去のRelease/tagとWorkflowを使用してください。現行mainにもV3.8 Samplerを残し、V3.8X2 Workflowを使えるようにしています。 +V3.9.2は`main`の現行ソースです。バージョンを固定したソースは[GitHub Releases](https://github.com/ukr8b3g-cmyk/ComfyUI-H3-Continuum/releases)から取得してください。ComfyUI Registryへの公開は別の作業です。過去のReleaseとtagも残します。設定済み1024×1024のReference-only GPU/APIテストは通っていますが、無改変の公式テンプレート初期設定とブラウザー保存・再読込は別の受入項目です。古い環境を厳密に再現するには対応する過去のRelease/tagとWorkflowを使用してください。現行mainにもV3.8 Samplerを残し、V3.8X2 Workflowを使えるようにしています。 -`pyproject.toml`の宣言上はComfyUI `>=0.32.0`ですが、以前の実生成・GPU検証はComfyUI `0.34.2`、上記の限定したFixedキャッシュ比較は`0.38.0`で行いました。最低宣言版でV3.9の実機動作を確認済みという意味ではありません。最新の記録済みWindows CPU試験は`1696 passed / 1 skipped / 0 failed`、以前の別環境Linux再実行報告は`1534 passed / 3 skipped / 0 failed`で、新しいキャッシュ/外部INT試験は含みません。これらは無改変の公式テンプレートの実ブラウザー保存・再読込やGPU受入を代替しません。 +`pyproject.toml`の宣言上はComfyUI `>=0.32.0`ですが、以前の実生成・GPU検証はComfyUI `0.34.2`、上記の限定したFixedキャッシュ比較は`0.38.0`で行いました。最低宣言版でV3.9の実機動作を確認済みという意味ではありません。以前のWindows CPU試験は`1696 passed / 1 skipped / 0 failed`、以前の別環境Linux再実行報告は`1534 passed / 3 skipped / 0 failed`で、新しいキャッシュ/外部INT試験は含みません。これらは無改変の公式テンプレートの実ブラウザー保存・再読込やGPU受入を代替しません。 ## V3.9 Reference Images diff --git a/REGISTRY_MANIFEST.sha256 b/REGISTRY_MANIFEST.sha256 index 3af445f..ac79faa 100644 --- a/REGISTRY_MANIFEST.sha256 +++ b/REGISTRY_MANIFEST.sha256 @@ -1,7 +1,7 @@ dca65fb1393e67f59c6f81f9411e3e745eb8f1097e9a2adf7ffc6f4e3901ca9f __init__.py 54ba2a58388c42063d24335aa2737e86bd4c15fe9632dcc9ffba18c328e04641 .comfyignore 3e7a1ec3380be2a222c8a3e9b8a6bb184d3a760478957f48186438f15235bdba branch_provenance.py -3a9cb2ac82d6a59e929017904d6a282fa2163368721044dd9c00c81627da95c8 CHANGELOG.md +2839ac42889341b018bc6013cfe7e5cf4cca81f3b80fae0620ac30612a5918e5 CHANGELOG.md c1ed3a0342730450958fb62fd21854a876991f3a4aefb24e5383b0c73cd2312d compatibility.py 4d62508f900af9f93ec320afb900c27cc9a300d1e0c0a94714258498c5ede5fc conditioning.py 294251c40b1be2e296c5e5f627b68091d087bdb39179e3a0c3cebd2ee8a344f5 constants.py @@ -42,15 +42,15 @@ bf0556b076dbaca67c3405a7d86c333ca7fdf3d4381529b0a9edc906519943e9 guide_timeline 139546ec1ff459945aa89b50f74b5ee69f62a0e07bbddfcae06936091a409a83 layout_adapter.py c44abbd789091bbead01250dbd5453e60539d2665c69f162335fdbd2936019c2 LICENSE d3e213005670e94dee33a240349a4d245cf9a3b6602099f11ed30cf5a32e2c21 media.py -ad0835f8fb6d171d8ff8d7295fb48291abc93ef02fd46a2e283265c15b93366a metadata.ini +a4b2b73c50ad05e4d6711e5db4a58c12cb98177ced27d29b2fb4e247761c5c01 metadata.ini d7e613e2cc24110213b477bdd1d390234a41f2af3b1ed006a809066d71d658eb model_patch.py ecb65a5dbf9e1683c5a3cadd82daaea3a90a2b776f6ebabfbe8b07aa93177422 nodes.py -1568dc8a5b5d8678f69846252ea10dbd33f7226f533c7767384516bdb8004fab PACKAGE_INFO_JA.txt -e98b150a8587fd67df53c0962ea86232eede355450c621f20fbb6d7ec9018ac7 PACKAGE_VALIDATION.txt +cd187770a30eba87f576da9baa7de8fb53ebfc7e739e8412e1558bf7ed161660 PACKAGE_INFO_JA.txt +3b729a12c3b89f88055267ef6a14e9df71752fa2d0c4d586d0e8b96a05d3ed7c PACKAGE_VALIDATION.txt b470819f16fc179654dc1600721a63f0a5a14e777f4c004d574b499da6886ba5 public_api.py -1047d05b0aedc405e3a36ee571a8939111d69bb5565e09a3e1caa3c40bf33170 pyproject.toml -0b7cd2a93c820955d1dc22f5a22d83ee25bf43bac67900b223fcddc6971f4cef README_JA.md -2cbe9848c0d3e477928c054c994e56adad706f3e8c2b8561b6ace17741faf770 README.md +ffbe4240d104d360c280a5d4743432520c265f1021c5f4668a977b22a6a8bddb pyproject.toml +65daf6eb0585c4850a0d306a00b801f9f356583f25e23be327f2dc7e98d7cdbd README_JA.md +9f60c0074efa406611a7433489d87f8b0e7bfbb9e1649b5bf14232ce9dc98641 README.md 9539f5cb9fb695841073fa58d9246d5a7410bc372f6cd340378185004dfaf978 reference_audio.py 5cb9bfd6810d3a93a637451980a4cc5c1436e5b84cfd1c7a111cd192e876351b reference_video.py caa572ea65dafc86850db99f52433d360ac9c4ab36b854292a3dccd5ba32dc76 reference.py @@ -128,7 +128,7 @@ d0a004aa3030c8adaa5ea788f9acc758fcb4a556f203f9a3f63fa4e4b5772063 v3/sampling_en 26b13614ba0a5fd8b192a106c9503b2f4b6fe7f9268a0fcb0f544979a49cab34 v3/video_adapter_nodes.py 4178dcfa442abdb06ce276e05bd7bcbaa6da28469ba5e57d3da3c663de4e4a9d v3/video_seam_v35.py 2f07ace1462644f0bee553827b3571535de4d0c2d9ef847bd9e0ca73a4eed5cb v3/video_seam.py -f1c9df5eb9f6c75bd0e505fb84731951fcd9ef1ab5d7f93a0c72f05488fa05fb version.py +76db0e3f2bba3e72050c6e35c47a1460fc5a74203d82aa63118b3f4e06ae4ac3 version.py b935ad3bb729948bb3890ce967b0ecbef737a5e51ddfc47a0060fc20aa78dcda video_reference_modes.py 685df8e0fa23e3663ab31da1e4470cd19bdaa0dc16362cb606e874d9d6153c2c web/decode_cache_helper.js fefafd4550511d80bd85ade46a0476f0cf3de13ddb94a908dff6b175f2a0e199 web/easy_bypass_toggle.js @@ -136,9 +136,9 @@ fefafd4550511d80bd85ade46a0476f0cf3de13ddb94a908dff6b175f2a0e199 web/easy_bypas 9db0aa94f634578a962d5db49e5c70356040a59df968e3a2e531b327a623081f web/easy_load_image.js 35090816ba7470a7255eb85d003b7e79f8a0065982dacf98a18f41c8ebff655d web/easy_load_video.js 0c68d13a1f8beb7431a32b471f8b0612c42fcc4bf72dd97611a025d158008662 web/easy_v38.js -fbceb922aa3a5ef54886f0ca4c1a07c516ec9fadca04080049ef11f15d584668 web/project_id.js +90bef8b7628106fffa95ac1e27e345fa3ccc7203bd2f608497f46b751f9bb850 web/project_id.js ae59273f163a116ece418957c557c4fd8c3285e3c60814679b9361d2e6e6fa02 web/reference_audio_ui.js 46c9f75c9462bf26300332448f4431cca801f38964ca0a49bc2c50a88a7cc40f web/reference_image_ui.js -e9d7753f313ebbe3d13e477f5b4e4767a735b0619b52ba54bcc5218f3eb7eb7c web/reference_images_v39.js +beea70f6e25e1366aba5e2689c31733478472f207dc50cad1562cd877152e4f9 web/reference_images_v39.js bf41bf08dd0504eb753fa5781e6c2b8c1285758ad4bb7309975bb9231d5f8e41 web/video_reference_mode_ui.js 7fd122ff08232e114a6ef32171217ea6324e980eb7257d560c466b8177a3d3ec audio_compat.py diff --git a/WORKLOG.md b/WORKLOG.md index 763f957..6261159 100644 --- a/WORKLOG.md +++ b/WORKLOG.md @@ -1,5 +1,15 @@ # Public development log +## 2026-10-13 — Issue #30 frontend hotfix, package 3.9.2 + +- Limit production changes to baseline-free Review snapshot skipping, one Reference selection notification per connected Sampler, and dimension checks before resizing the Reference helper. Align package metadata and current public guidance with 3.9.2; retain 3.9.1 records as history. +- Keep Review drawing-time upstream monitoring when a baseline exists and fresh synchronous Take/Queue checks. Preserve native callbacks, immediate saved assignment values, public widget/socket order and official workflow bytes. +- Add frontend regression coverage for upstream widget/link edits, rapid Reference selections, All/Off with future assignments, helper reconfiguration and independent helpers/Samplers. Track the independent Inspector reconfigure bug at 2 and 100 passes with explicit expected failures; one-pass refresh must succeed. +- Browser checks use isolated Chromium DOM and graph fixtures without generation. Full ComfyUI canvas, mobile performance and live workflow acceptance remain separate checks. +- Validation: 1,703 CPU/JavaScript regression cases passed, 2 skipped and 2 expected failures for the independent Inspector bug; zero CUDA initialization attempts. Offline runtime planning and twelve-node registration passed. In isolated Chromium, 600 baseline-free draw callbacks made zero snapshots (previously 600); 30 connected Reference checks notified the Sampler 30 times (previously 60), with zero same-dimension resize calls (previously 30). DOM rebuilds remain, and mobile freeze resolution is unconfirmed. + +- Final 3.9.2 candidate CPU gate passed 1,703 cases with 2 skips and 2 explicit Inspector expected failures. The actual Core/frontend/LiteGraph browser smoke passed checkbox interactions, Prompt/link/Bypass edit/restore and native assignment graph reload without submitting a prompt. This desktop headless/model-free check is separate from UI file-save, mobile hardware and stored-Take acceptance. + ## 2026-10-04 — V3.9 stability patch, package 3.9.1 - Preserve Second Pass audio/mixed-keyframe conditions and inherit the conditioning and References belonging to the selected Review output. diff --git a/docs/VALIDATION_JA.md b/docs/VALIDATION_JA.md index a1cf99e..312f279 100644 --- a/docs/VALIDATION_JA.md +++ b/docs/VALIDATION_JA.md @@ -1,6 +1,6 @@ -# H3 Continuum 3.9.1 — 検証手順と受入範囲 +# H3 Continuum 3.9.2 — 検証手順と受入範囲 -現行版はパッケージ3.9.1、公開12ノードです。引き続きV3.9ノードを使用します。 +現行版はパッケージ3.9.2、公開12ノードです。引き続きV3.9ノードを使用します。 旧版の検証手順は末尾に履歴として残しています。 ## CPU・登録確認 @@ -19,12 +19,25 @@ pytestが実Coreを必要とするケースまで実行したかは、結果の Coreがないstandalone環境では、実Core依存18件を明示的にスキップします。 Core内部の依存エラーや計算エラーをスキップで隠す設計ではありません。 -記録済みの結果は環境別です。実Coreの全CPUは1,696成功・1スキップ、公開CIは +3.9.2のFrontend修正の実Core CPUは1703成功・2スキップ・2期待失敗です。 +期待失敗は、独立したInspector再configure問題の2条件を追跡します。 +公開候補の最終試験・CI・実画面の記録はPACKAGE_VALIDATION.txtを参照してください。 + +以前の3.9.1の結果は環境別です。実Coreの全CPUは1,696成功・1スキップ、公開CIは 1,676成功・21スキップです。CIの21件は実Core依存18件と既存環境制約3件です。 詳細・対象コミットは[PACKAGE_VALIDATION.txt](../PACKAGE_VALIDATION.txt)を参照し、 異なる環境の件数を単純合算しないでください。 -## 実ブラウザー受入 +## Issue #30の限定ブラウザー確認 + +GPU生成を行わず、分離した検証WorkflowでReference単体・Sampler単体・接続時を +比較します。無操作、パン/ズーム、連続チェック、All/Off、複数helper/Sampler、 +接続変更、Chunks縮小・復元、native値の保存・再読込を確認します。 +Review比較基準がある場合は上流widget/接続/Bypassの変更と元に戻す操作、 +最新設定でのTake/Queueガードを確認します。Inspector再configure問題は別件です。 +実モバイルの解消確認、既存実Runの採用・生成確認とは区別して記録します。 + +## 実ブラウザー受入(全体の確認項目) 生成中のワークフローを再起動・置換せず、実行中と待機中のキューが空の状態で 検証用Workflowを使用します。元Workflowと採用済みTakeを先に保存してください。 @@ -42,7 +55,7 @@ Canvasの表示だけ、API登録だけ、DOM代替のJSテストだけで、保 実ブラウザーPASSとはしません。検証用Workflowの合格も、無改変公式Workflowの 初期設定でのGPU受入とは区別します。 -## 修正対象のGPU Gate +## 以前の3.9.1生成修正のGPU Gate - R1/Review Second Pass: audio-only/mixed keyframes、partial prefix、 中央Chunk単独、complete sequenceを確認します。出力group自身のconditioning、 @@ -53,7 +66,7 @@ Canvasの表示だけ、API登録だけ、DOM代替のJSテストだけで、保 Exact ON/OFFとも一度だけ切り出すことを確認します。 - 保存済みTakeのJSON/raw、動画と音声の尺、CUDA/OOM/NaN、残留キューも記録します。 -対象修正のGPU確認は記録済みですが、ブラウザー受入、無改変公式Workflow全体、 +以前の3.9.1対象修正のGPU確認は記録済みですが、ブラウザー受入、無改変公式Workflow全体、 全アクセラレータ構成や総合画質の受入まで済んだとは扱いません。 任意LATENT拡大の二重輪郭は[Issue #27](https://github.com/ukr8b3g-cmyk/ComfyUI-H3-Continuum/issues/27) として分けて扱います。 @@ -66,15 +79,15 @@ Canvasの表示だけ、API登録だけ、DOM代替のJSテストだけで、保 同一VAEオブジェクトの重みを直接変更した場合は、Reference Encode Cacheを 明示的にクリアするか、VAEを再読込してください。 -GitHub ReleaseとRegistry公開は別作業です。公開済みv3.9.1 tagは保持し、後続の -文書訂正はmainで参照してください。 +GitHub ReleaseとRegistry公開は別作業です。公開版はGitHub Releasesで確認し、 +過去のv3.9.1 tagも保持します。3.9.1からのUI hotfixではRun/Takeの移行は不要です。 --- ## 履歴:V2専用の旧検証手順 以下は当時の記録です。V1/V2ノード数、`strict_compatibility`、旧Session再開手順を -3.9.1の現行仕様や受入結果として使用しないでください。 +3.9.2の現行仕様や受入結果として使用しないでください。 # H3 Continuum Join 2.0 — 実機検証 diff --git a/metadata.ini b/metadata.ini index cc27602..11bf7c0 100644 --- a/metadata.ini +++ b/metadata.ini @@ -1,4 +1,4 @@ [project] name = H3 Continuum -version = 3.9.1 +version = 3.9.2 description = Native MiniMax H3 masked AV continuation, Second Pass, and disk-backed assembly. diff --git a/pyproject.toml b/pyproject.toml index cb2d591..55db0de 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,6 +1,6 @@ [project] name = "comfyui-h3-continuum" -version = "3.9.1" +version = "3.9.2" description = "Integrated N-chunk continuation for ComfyUI native MiniMax H3 video and audio" readme = "README.md" requires-python = ">=3.10" diff --git a/tests/frontend_issue30_ui.cjs b/tests/frontend_issue30_ui.cjs new file mode 100644 index 0000000..5bb29cc --- /dev/null +++ b/tests/frontend_issue30_ui.cjs @@ -0,0 +1,131 @@ +// Exercise the complete production scripts through the existing Queue fixture. +// DOM, graph and server responses are fixtures; no ComfyUI service or GPU is used. +const assert = require('node:assert/strict'); +const fs = require('node:fs'); +const path = require('node:path'); +const vm = require('node:vm'); +const ROOT = process.env.H3_TEST_ROOT || path.resolve(__dirname, '..'); +const harness = fs.readFileSync(path.join(ROOT, 'tests/frontend_review_queue.cjs'), 'utf8'); +const marker = harness.indexOf('\n(async()=>{'); +assert(marker > 0); +function dom(tag) { + return { tag, children: [], style: {}, textContent: '', + append(...items) { this.children.push(...items); }, + replaceChildren(...items) { this.children = items; }, + addEventListener() {}, setAttribute(name, value) { this[name] = value; } }; +} +const scope = { require, process, console, __dirname: path.join(ROOT, 'tests'), + setTimeout, clearTimeout, setImmediate, structuredClone, + document: { createElement: dom } }; +const prefix = harness.slice(0, marker) + .replace('globalThis:null,', 'globalThis:null,document,') + .replace('reviewSettingsChanged,synchronizeReviewQueue};', + 'reviewSettingsChanged,reviewSettingsSnapshot,synchronizeReviewQueue};'); +vm.runInNewContext(prefix + '\nglobalThis.fixtures={environment,project};', scope); +const { environment, project } = scope.fixtures; +const results = []; +async function test(name, body, knownIssue = null) { + const e = environment(); + try { await body(e); results.push({ name, pass: true, knownIssue }); } + catch (error) { results.push({ name, pass: false, knownIssue, error: error.stack }); } + finally { e.close(); } +} +function upstream(e, n, count = 20) { + let previous = n; + for (let i = 0; i < count; i++) { + const source = { id: 900 + i, comfyClass: 'FixtureSource', mode: 0, + widgets: [{ name: 'text', value: `source-${i}`, options: {} }], inputs: [] }; + e.app.graph._nodes.push(source); + previous.inputs.push({ name: 'source', link: 70 + i }); + e.app.graph.links[70 + i] = { origin_id: source.id, origin_slot: 0 }; + previous = source; + } + return previous; +} +function helper(e, n) { + const h = e.makeNode(391, 'helper', 'H3ContinuumReferenceImagesV39', false); + h.widgets = [{ name: 'reference_use', value: 'Per chunk', options: {} }, + ...Array.from({ length: 9 }, (_, i) => ({ name: `reference_r${i + 1}_chunks`, value: 'off', options: {} }))]; + h.inputs = [{ name: 'reference_image_1', link: 600 }]; + h.outputs = [{ name: 'reference_images', links: [900] }]; + h.addDOMWidget = function(_name, _type, host, options) { + this.panel = host.children[0]; this.display = { options }; return this.display; + }; + h.computeSize = function() { return [this.size[0], 310 + this.display.computeSize(this.size[0])[1]]; }; + h.setSize = function(size) { this.size = size; }; + e.app.graph.links[900] = { origin_id: h.id, target_id: n.id, origin_slot: 0 }; + n.inputs.push({ name: 'reference_images', link: 900 }); + e.f.configureNode(h); + return h; +} +(async () => { + await test('no Review baseline: draw does not traverse upstream settings', async e => { + const n = e.makeNode(); upstream(e, n); + let lookups = 0, refreshes = 0; + const get = e.app.graph.getNodeById; + e.app.graph.getNodeById = function(...args) { lookups++; return get.apply(this, args); }; + n.__h3ContinuumIntuitiveUxRefresh = n.__h3ContinuumProductionUxRefresh = () => { refreshes++; }; + for (const baseline of [undefined, null]) { + n.__h3ContinuumReviewedSettings = baseline; + n.__h3ContinuumReviewDrawChanged = false; + for (let i = 0; i < 600; i++) n.onDrawForeground(); + assert.equal(e.f.reviewSettingsChanged(n), false); + } + assert.equal(lookups, 0); assert.equal(refreshes, 0); + n.__h3ContinuumReviewedSettings = ''; + assert.equal(e.f.reviewSettingsChanged(n), true, 'an existing empty baseline still requires comparison'); + assert.equal(lookups, 20); + }); + await test('Review baseline: every draw still detects upstream edits', async e => { + const n = e.makeNode(), last = upstream(e, n); + n.__h3ContinuumReviewedSettings = e.f.reviewSettingsSnapshot(n); + n.__h3ContinuumReviewDrawChanged = false; + let lookups = 0, refreshes = 0; + const get = e.app.graph.getNodeById; + e.app.graph.getNodeById = function(...args) { lookups++; return get.apply(this, args); }; + n.__h3ContinuumIntuitiveUxRefresh = n.__h3ContinuumProductionUxRefresh = () => { refreshes++; }; + for (let i = 0; i < 600; i++) n.onDrawForeground(); + assert.equal(lookups, 12000); assert.equal(refreshes, 0); + last.widgets[0].value = 'edited'; + n.onDrawForeground(); + assert.equal(n.__h3ContinuumReviewDrawChanged, true); + assert.equal(refreshes, 2); + }); + for (const nodeClass of ['H3ContinuumSamplerV38', 'H3ContinuumSamplerV39']) { + for (const change of ['widget', 'link']) { + await test(`${nodeClass}: ${change} edit keeps immediate Take and draw guards`, async e => { + const n = e.makeNode(312, 'fixture', nodeClass), source = upstream(e, n, 1); + e.w(n, 'generation_mode').value = 'Review Each Chunk'; + await e.load(n, project(1)); + delete n.__h3ContinuumModeSetup; + n.__h3ContinuumReviewedSettings = e.f.reviewSettingsSnapshot(n); + n.__h3ContinuumProductionUxRefresh(); n.onDrawForeground(); + assert(e.visible(n, 'Use it and continue')); + if (change === 'widget') source.widgets[0].value = 'edited'; + else e.app.graph.links[70].origin_slot = 1; + assert(e.visible(n, 'Use it and continue'), 'no draw has occurred yet'); + e.f.selectTakeAction(n, 'Use This Take'); + assert.equal(e.w(n, 'take_action').value, 'Automatic'); + assert.equal(e.w(n, 'take_revision_id').value, ''); + n.onDrawForeground(); + assert(!e.visible(n, 'Use it and continue')); + assert.match(e.w(n, 'Review Ready').headline, /Settings changed/); + assert.equal(e.submissions.length, 0); + }); + } + } + for (const passes of [1, 2, 100]) { + await test(`Reference Inspector stays current after ${passes} configure passes`, async e => { + const n = e.makeNode(312, 'fixture', 'H3ContinuumSamplerV39', false), h = helper(e, n); + for (let i = 0; i < passes; i++) e.f.configureNode(n); + n.onExecuted({ h3_reference_plan: ['fixture verified plan'] }); + const plan = e.w(n, 'Reference Plan Inspector'); + assert.equal(plan.value, 'fixture verified plan'); + h.widgets[1].value = '1'; h.widgets[1].callback('1'); + assert.equal(n.__h3ContinuumReferencePlan, null); + assert.notEqual(plan.value, 'fixture verified plan', 'an invalidated plan must not keep its verified display'); + }, passes > 1 ? 'inspector-reconfigure' : null); + } + console.log(JSON.stringify(results)); + if (results.some(item => !item.pass && !item.knownIssue)) process.exitCode = 1; +})(); diff --git a/tests/frontend_reference_images_v39.cjs b/tests/frontend_reference_images_v39.cjs index 5eb2ff2..263704b 100644 --- a/tests/frontend_reference_images_v39.cjs +++ b/tests/frontend_reference_images_v39.cjs @@ -24,8 +24,11 @@ const { configureV39ReferenceImages, refreshV39ReferenceImagesForSampler, connectedV39LegacyReferenceInputs, pruneV39LegacyReferenceInputs, } = sandbox.v39; +const nativeCalls = []; +let resizeCalls = 0; const selectors = Array.from({ length: 9 }, (_, i) => ({ name: `reference_r${i + 1}_chunks`, value: 'off', type: 'text', options: {}, + callback(...args) { nativeCalls.push({ receiver: this, args }); return 'native-result'; }, })); const mode = { name: 'reference_use', value: 'All chunks', type: 'combo', options: {} }; const helper = { @@ -36,13 +39,15 @@ const helper = { outputs: [{ name: 'reference_images', links: [10] }], addDOMWidget(_name, _type, host, options) { this.host = host; this.panel = host.children[0]; this.domOptions = options; this.display = { options: {} }; return this.display; }, computeSize() { return [this.size[0], 310 + this.display.computeSize(this.size[0])[1]]; }, - setSize(size) { this.size = size; }, + setSize(size) { resizeCalls++; this.size = size; }, setDirtyCanvas() {}, }; const chunks = { name: 'chunks', value: 6 }; const sampler = { id: 2, graph, comfyClass: 'H3ContinuumSamplerV39', widgets: [chunks], inputs: [{ name: 'reference_images', link: 10 }], + refreshes: 0, + __h3ContinuumIntuitiveUxRefresh() { this.refreshes++; }, __h3ContinuumReferencePlan: 'verified', setDirtyCanvas() {}, }; graph.nodes.set(1, helper); graph.nodes.set(2, sampler); @@ -72,7 +77,14 @@ function click(slot, chunk) { const box = visit(helper.panel, (item) => item.tag === 'input' && item['aria-label'] === `Image ${slot}, Chunk ${chunk}`); assert(box, `missing Image ${slot} / Chunk ${chunk}`); + const before = { notifications: sampler.refreshes, native: nativeCalls.length, sizes: resizeCalls, width: helper.size[0] }; box.checked = !box.checked; box.onchange(); + assert.equal(sampler.refreshes, before.notifications + 1, 'one synchronous Sampler notification per checkbox'); + assert.equal(nativeCalls.length, before.native + 1, 'preserve the native callback exactly once'); + assert.equal(nativeCalls.at(-1).receiver, selectors[slot - 1]); + assert.equal(nativeCalls.at(-1).args[0], selectors[slot - 1].value); + assert.equal(resizeCalls, before.sizes, 'selection changes must not resize an unchanged layout'); + assert.equal(helper.size[0], before.width, 'keep the manually chosen width'); } for (const chunk of [1, 3, 6]) click(1, chunk); assert.equal(selectors[0].value, '1,3,6'); @@ -80,6 +92,28 @@ assert.equal(sampler.__h3ContinuumReferencePlan, null); chunks.value = 3; refreshV39ReferenceImagesForSampler(sampler); assert.match(helper.panel.children.find((item) => item.textContent.startsWith('Image 1 →')).textContent, /saved beyond range: 6/); assert.equal(selectors[0].value, '1,3,6'); +function action(label) { + const row = visit(helper.panel, (item) => item.tag === 'tr' + && item.children[0]?.textContent === 'Image 1 · @R1'); + const button = visit(row, (item) => item.tag === 'button' && item.textContent === label); + assert(button && !button.disabled); + const before = { notifications: sampler.refreshes, native: nativeCalls.length, sizes: resizeCalls }; + button.onclick(); + assert.equal(sampler.refreshes, before.notifications + 1, 'one notification per All / Off'); + assert.equal(nativeCalls.length, before.native + 1); + assert.equal(resizeCalls, before.sizes); +} +action('All'); +assert.equal(selectors[0].value, '1,2,3,6', 'All preserves saved chunks beyond the current range'); +action('Off'); +assert.equal(selectors[0].value, '6', 'Off preserves saved chunks beyond the current range'); +selectors[0].value = '1,3,6'; +const nativeBefore = nativeCalls.length; +const refreshBefore = sampler.refreshes; +assert.equal(selectors[0].callback('1,3,6', 'native-edit'), 'native-result'); +assert.equal(nativeCalls.length, nativeBefore + 1); +assert.equal(nativeCalls.at(-1).args[1], 'native-edit'); +assert.equal(sampler.refreshes, refreshBefore + 1); chunks.value = 6; refreshV39ReferenceImagesForSampler(sampler); assert.equal(selectors[0].value, '1,3,6'); mode.value = 'All chunks'; mode.callback('All chunks'); @@ -92,6 +126,51 @@ chunks.value = 16; helper.__h3ReferenceImagesRefresh(); assert.equal(helper.display.computeSize(440)[1], 368); assert.equal(helper.panel.style.height, '360px'); +const stableSizes = resizeCalls; +const wrappedCallback = selectors[0].callback; +for (let i = 0; i < 100; i++) configureV39ReferenceImages(helper); +assert.equal(selectors[0].callback, wrappedCallback, 'helper reconfiguration must not stack callbacks'); +assert.equal(resizeCalls, stableSizes); +helper.size[0] = 620; +click(1, 2); +assert.equal(helper.size[0], 620); +// Check another connected Sampler independently of the manually chosen width. +helper.size[0] = 440; +const secondSampler = { ...sampler, id: 3, refreshes: 0, widgets: [{ name: 'chunks', value: 16 }] }; +graph.nodes.set(3, secondSampler); +graph.links[11] = { origin_id: 1, target_id: 3 }; +helper.outputs[0].links.push(11); +click(1, 3); +assert.equal(secondSampler.refreshes, 1, 'each connected Sampler receives the selection'); +assert.equal(secondSampler.__h3ContinuumReferencePlan, null); +const separateSampler = { ...sampler, id: 5, refreshes: 0, widgets: [{ name: 'chunks', value: 16 }], + __h3ContinuumReferencePlan: 'verified' }; +const separateHelper = { + id: 4, graph, comfyClass: helper.comfyClass, size: [440, 500], + widgets: [{ name: 'reference_use', value: 'Per chunk', options: {} }, + ...Array.from({ length: 9 }, (_, i) => ({ name: `reference_r${i + 1}_chunks`, value: 'off', options: {} }))], + inputs: helper.inputs.map((input) => ({ ...input })), + outputs: [{ name: 'reference_images', links: [12] }], + addDOMWidget: helper.addDOMWidget, computeSize: helper.computeSize, + setSize: helper.setSize, setDirtyCanvas() {}, +}; +graph.nodes.set(4, separateHelper); graph.nodes.set(5, separateSampler); +graph.links[12] = { origin_id: 4, target_id: 5 }; +configureV39ReferenceImages(separateHelper); +const firstBefore = sampler.refreshes; +click(1, 4); +const separateBox = visit(separateHelper.panel, (item) => item.tag === 'input' + && item['aria-label'] === 'Image 1, Chunk 5'); +separateBox.checked = true; separateBox.onchange(); +assert.equal(sampler.refreshes, firstBefore + 1); +assert.equal(separateSampler.refreshes, 1, 'independent helpers must not cancel each other'); +assert.equal(separateHelper.widgets[1].value, '5'); +assert.equal(separateSampler.__h3ContinuumReferencePlan, null); +delete graph.links[12]; separateHelper.outputs[0].links = []; +separateHelper.onConnectionsChange(); +const detachedRefreshes = separateSampler.refreshes; +separateHelper.widgets[1].value = '6'; separateHelper.widgets[1].callback('6'); +assert.equal(separateSampler.refreshes, detachedRefreshes, 'disconnected Samplers are not notified'); const oldSampler = { comfyClass: 'H3ContinuumSamplerV39', __h3ContinuumReferencePlan: 'old plan', diff --git a/tests/test_issue30_frontend.py b/tests/test_issue30_frontend.py new file mode 100644 index 0000000..0eae80a --- /dev/null +++ b/tests/test_issue30_frontend.py @@ -0,0 +1,54 @@ +"""Issue #30 overhead regression, with the independent Inspector bug tracked.""" +import json +import os +from pathlib import Path +import shutil +import subprocess + +import pytest + +ROOT = Path(__file__).resolve().parents[1] + + +def run_frontend(filename): + node = shutil.which("node") + assert node, "Node.js is required for frontend regression tests" + return subprocess.run( + [node, str(ROOT / "tests" / filename)], + env={**os.environ, "H3_TEST_ROOT": str(ROOT)}, + capture_output=True, text=True, encoding="utf-8", timeout=45, + ) + + +def test_reference_selection_notifications_and_layout(): + result = run_frontend("frontend_reference_images_v39.cjs") + assert result.returncode == 0, result.stdout + result.stderr + + +@pytest.fixture(scope="module") +def issue30_results(): + result = run_frontend("frontend_issue30_ui.cjs") + assert result.returncode == 0, result.stdout + result.stderr + records = json.loads(result.stdout) + assert len(records) == 9 + for record in records: + if record["knownIssue"] and not record["pass"]: + assert "an invalidated plan must not keep its verified display" in record.get("error", ""), record + return {record["name"]: record for record in records} + + +@pytest.mark.parametrize("name", [ + "no Review baseline: draw does not traverse upstream settings", + "Review baseline: every draw still detects upstream edits", + *[f"{node_class}: {change} edit keeps immediate Take and draw guards" + for node_class in ("H3ContinuumSamplerV38", "H3ContinuumSamplerV39") + for change in ("widget", "link")], + "Reference Inspector stays current after 1 configure passes", + pytest.param("Reference Inspector stays current after 2 configure passes", marks=pytest.mark.xfail( + strict=True, reason="Independent Inspector refresh hook is lost on Sampler reconfigure")), + pytest.param("Reference Inspector stays current after 100 configure passes", marks=pytest.mark.xfail( + strict=True, reason="Independent Inspector refresh hook is lost on Sampler reconfigure")), +]) +def test_issue30_frontend_paths(issue30_results, name): + record = issue30_results[name] + assert record["pass"], record.get("error", name) diff --git a/tests/test_release_metadata.py b/tests/test_release_metadata.py index f07adbe..5622d33 100644 --- a/tests/test_release_metadata.py +++ b/tests/test_release_metadata.py @@ -6,7 +6,7 @@ import tomllib ROOT = Path(__file__).resolve().parents[1] -EXPECTED_VERSION = "3.9.1" +EXPECTED_VERSION = "3.9.2" def test_v35_release_metadata_is_consistent(): diff --git a/tests/test_v217_stable_facade.py b/tests/test_v217_stable_facade.py index 2e1a3f1..1639e8a 100644 --- a/tests/test_v217_stable_facade.py +++ b/tests/test_v217_stable_facade.py @@ -145,4 +145,4 @@ def test_v217_result_pack_expands_legacy_outputs(): def test_v217_has_no_frontend_display_controller(): assert not (ROOT / "web" / "h3_continuum_v2.js").exists() version_source = (ROOT / "version.py").read_text(encoding="utf-8") - assert 'PACKAGE_VERSION = "3.9.1"' in version_source + assert 'PACKAGE_VERSION = "3.9.2"' in version_source diff --git a/version.py b/version.py index b0bda91..a8a55e7 100644 --- a/version.py +++ b/version.py @@ -1,6 +1,6 @@ """Package version and public schema identifiers.""" -PACKAGE_VERSION = "3.9.1" +PACKAGE_VERSION = "3.9.2" STATE_SCHEMA_VERSION = 1 PLAN_SCHEMA_VERSION = 1 PUBLIC_API_VERSION = 3 diff --git a/web/project_id.js b/web/project_id.js index 75ccb7d..7bd23a5 100644 --- a/web/project_id.js +++ b/web/project_id.js @@ -1507,8 +1507,9 @@ function reviewSettingsSnapshot(node) { function reviewSettingsChanged(node) { const baseline = node.__h3ContinuumReviewedSettings; + if (baseline == null) return false; const current = reviewSettingsSnapshot(node); - return baseline != null && current != null && current !== baseline; + return current != null && current !== baseline; } function rememberReviewSettings(node, requestedSettings) { diff --git a/web/reference_images_v39.js b/web/reference_images_v39.js index 57906cc..d45d54b 100644 --- a/web/reference_images_v39.js +++ b/web/reference_images_v39.js @@ -107,8 +107,10 @@ export function configureV39ReferenceImages(node) { panelHeight = height; panel.style.height = `${height}px`; const computedHeight = Number(node.computeSize?.()[1]); - if (Number.isFinite(computedHeight) && typeof node.setSize === "function") { - node.setSize([Number(node.size?.[0]) || 340, computedHeight]); + const width = Number(node.size?.[0]) || 340; + if (Number.isFinite(computedHeight) && typeof node.setSize === "function" + && (Number(node.size?.[0]) !== width || Number(node.size?.[1]) !== computedHeight)) { + node.setSize([width, computedHeight]); } }; let page = 0; @@ -116,9 +118,8 @@ export function configureV39ReferenceImages(node) { const setSelection = (slot, selection) => { const target = selectors[slot - 1]; target.value = [...selection].sort((a, b) => a - b).join(",") || "off"; + // The wrapped native callback owns invalidation and the immediate refresh. target.callback?.(target.value); - invalidate(node); - refresh(); }; const refresh = () => { const { count, known } = destination(node);