From 0e204ada43f65b16082669d28afde33ec1b22299 Mon Sep 17 00:00:00 2001 From: "chris.dumas" Date: Sat, 7 Nov 2026 21:27:17 +0000 Subject: [PATCH] Show ComfyUI audio outputs in portal --- e2e/portal.spec.js | 14 ++++++++++++++ frontend/src/app/pages/jobs.page.html | 2 +- frontend/src/app/pages/jobs.page.scss | 2 +- frontend/src/app/pages/jobs.page.ts | 1 + server.js | 16 ++++++++++++++-- server.test.js | 25 +++++++++++++++++++++++++ 6 files changed, 56 insertions(+), 4 deletions(-) diff --git a/e2e/portal.spec.js b/e2e/portal.spec.js index 69b8605..1766f6c 100644 --- a/e2e/portal.spec.js +++ b/e2e/portal.spec.js @@ -245,6 +245,20 @@ test.describe('ComfyUI Portal read-only UI states', () => { await expect(page.locator('figure a')).toHaveAttribute('rel', 'noopener'); }); + test('renders audio assets with a native player and safe output link', async ({ page }) => { + const jobs = [{ + promptId: 'audio-1', title: 'Neo-soul piano', status: 'completed', queuedAt: 1000, + durationMs: 60000, outputCount: 1, + assets: [{ filename: 'neo_soul.flac', url: '/api/assets?filename=neo_soul.flac&subfolder=&type=output', type: 'audio' }], + models: [], progress: null, + }]; + await mockReadOnlyApi(page, { jobs }); + await page.goto('/jobs'); + await expect(page.locator('audio')).toHaveAttribute('src', /filename=neo_soul\.flac/); + await expect(page.getByText('neo_soul.flac')).toBeVisible(); + await expect(page.locator('figure a')).toHaveAttribute('target', '_blank'); + }); + test('shows a clear jobs error while retaining server status', async ({ page }) => { await mockReadOnlyApi(page, { jobs: 'unavailable' }); await page.goto('/jobs'); diff --git a/frontend/src/app/pages/jobs.page.html b/frontend/src/app/pages/jobs.page.html index 96a1fd3..8704570 100644 --- a/frontend/src/app/pages/jobs.page.html +++ b/frontend/src/app/pages/jobs.page.html @@ -6,5 +6,5 @@
CURRENTLY RUNNING

{{runningJob.title}}

running
{{runningJob.progress ? (runningJob.progress.percent + '% complete') : 'Working…'}}
ID {{runningJob.promptId}}Started {{formatClock(runningJob.queuedAt)}}Running for {{runningDuration()}}
Models{{model.name}}
{{error}}
Loading remote jobs…
No remote jobs were returned.
-

{{job.title}}

{{job.status}}
ID {{job.promptId}}{{job.outputCount}} output{{job.outputCount===1?'':'s'}}Duration {{formatDuration(job.durationMs)}}
Models{{model.name}}
{{asset.filename}}{{asset.width}} × {{asset.height}}{{formatFileSize(asset.sizeBytes)}}
No output assets
+

{{job.title}}

{{job.status}}
ID {{job.promptId}}{{job.outputCount}} output{{job.outputCount===1?'':'s'}}Duration {{formatDuration(job.durationMs)}}
Models{{model.name}}
{{asset.filename}}{{asset.width}} × {{asset.height}}{{formatFileSize(asset.sizeBytes)}}
No output assets
diff --git a/frontend/src/app/pages/jobs.page.scss b/frontend/src/app/pages/jobs.page.scss index 2b7dce0..1f54313 100644 --- a/frontend/src/app/pages/jobs.page.scss +++ b/frontend/src/app/pages/jobs.page.scss @@ -1,6 +1,6 @@ .heading{display:flex;justify-content:space-between;align-items:start;gap:1rem;margin-bottom:2rem}.eyebrow{font-size:.75rem;font-weight:800;letter-spacing:.12em;color:#3b82f6}h1{margin:.35rem 0}.heading p{color:#63738a}.refresh{padding:.65rem 1rem;border:1px solid #cbd5e1;border-radius:8px;background:#fff;cursor:pointer}.server-card{background:#18283d;color:#fff;border-radius:14px;padding:1.25rem;margin-bottom:1.5rem}.server-heading{display:flex;justify-content:space-between;align-items:start}.server-heading h2{margin:.35rem 0 0;font-size:1.05rem}.connection{background:#bbf7d0;color:#166534;border-radius:999px;padding:.3rem .6rem;font-size:.75rem;font-weight:700}.connection.offline{background:#fecaca;color:#991b1b}.queue-panel{display:flex;gap:1.5rem;align-items:center;margin-top:1.25rem;padding:1rem;background:#243952;border-radius:10px}.queue-panel div{display:flex;flex-direction:column;gap:.15rem}.queue-panel strong{font-size:1.35rem}.queue-panel span{color:#aab8cb;font-size:.75rem}.server-info{display:grid;grid-template-columns:repeat(auto-fit,minmax(150px,1fr));gap:1rem;margin-top:1.25rem}.server-info div{display:flex;flex-direction:column;gap:.25rem}.server-info span,.device span{color:#aab8cb;font-size:.75rem}.server-info strong{font-size:.85rem;overflow:hidden;text-overflow:ellipsis;white-space:nowrap}.devices{display:grid;gap:.5rem;margin-top:1.25rem}.device{display:flex;justify-content:space-between;gap:1rem;border-top:1px solid #34465d;padding-top:.7rem}.server-error{color:#fecaca;margin-top:1rem;font-size:.85rem}.grid{display:grid;grid-template-columns:repeat(auto-fit,minmax(340px,1fr));gap:1rem}.job{background:#fff;border:1px solid #dce3ed;border-radius:14px;padding:1.25rem}.jobhead{display:flex;justify-content:space-between;gap:1rem}.job h2{font-size:1rem;margin:0;color:#18283d}.status{font-size:.75rem;border-radius:999px;padding:.25rem .55rem;background:#e8eef7}.status.completed{background:#dcfce7;color:#166534}.status.failed{background:#fee2e2;color:#991b1b}.meta{display:flex;flex-wrap:wrap;gap:.5rem 1rem;color:#63738a;font-size:.8rem;margin-top:.8rem}.models{display:flex;flex-wrap:wrap;align-items:center;gap:.4rem;margin-top:1rem;font-size:.75rem}.models strong{color:#42526b}.models span{background:#eef2ff;color:#3730a3;border-radius:6px;padding:.3rem .45rem;max-width:100%;overflow:hidden;text-overflow:ellipsis;white-space:nowrap}.assets{display:grid;grid-template-columns:repeat(auto-fill,minmax(120px,1fr));gap:.6rem;margin-top:1rem}.assets figure{margin:0;min-width:0}.assets a{display:block;aspect-ratio:1;background:#f1f5f9;border-radius:8px;overflow:hidden}.assets img,.assets video{display:block;width:100%;height:100%;object-fit:cover}.assets figcaption{font-size:.7rem;color:#63738a;overflow:hidden;text-overflow:ellipsis;white-space:nowrap;margin-top:.3rem}.no-assets{margin-top:1rem;color:#94a3b8;font-size:.8rem}.notice{padding:1rem;background:#fff1f0;color:#b42318;border-radius:10px}.loading,.empty{padding:3rem;text-align:center;color:#63738a} .model-stats{background:#fff;border:1px solid #dce3ed;border-radius:14px;padding:1.1rem 1.25rem;margin-bottom:1.5rem}.stats-heading{display:flex;justify-content:space-between;align-items:end;gap:1rem}.stats-heading h2{margin:.35rem 0 0;font-size:1.05rem;color:#18283d}.stats-heading>span{color:#63738a;font-size:.75rem}.stats-list{list-style:none;margin:1rem 0 0;padding:0;display:grid;gap:.5rem}.stats-list li{display:grid;grid-template-columns:1.6rem minmax(0,1fr) auto;align-items:center;gap:.6rem;padding:.55rem .65rem;background:#f8fafc;border-radius:8px}.stats-list strong{overflow:hidden;text-overflow:ellipsis;white-space:nowrap;color:#18283d;font-size:.85rem}.rank{color:#64748b;font-size:.75rem;font-weight:700}.usage{color:#63738a;font-size:.75rem}.stats-empty{padding:1rem 0 0;color:#63738a;font-size:.8rem} .running-card{background:#fff;border:1px solid #93c5fd;border-radius:14px;padding:1.25rem;margin-bottom:1.5rem;box-shadow:0 6px 20px rgba(59,130,246,.08)}.running-heading{display:flex;justify-content:space-between;align-items:start;gap:1rem}.running-heading h2{margin:.35rem 0 0;font-size:1.05rem;color:#18283d}.progress-track{height:10px;background:#dbeafe;border-radius:999px;overflow:hidden;margin-top:1.25rem}.progress-value{height:100%;background:#2563eb;border-radius:inherit;transition:width .4s ease}.progress-track.indeterminate .progress-value{width:35%!important;animation:progress-slide 1.4s ease-in-out infinite}.progress-label{color:#42526b;font-size:.75rem;margin-top:.45rem}@keyframes progress-slide{0%{margin-left:-35%}100%{margin-left:100%}} -.assets figcaption{display:flex;flex-direction:column;gap:.2rem;font-size:.7rem;color:#63738a;overflow:hidden;margin-top:.3rem}.assets figcaption strong{overflow:hidden;text-overflow:ellipsis;white-space:nowrap;font-weight:600}.asset-meta{display:flex;gap:.5rem;color:#94a3b8;font-size:.68rem} +.assets figcaption{display:flex;flex-direction:column;gap:.2rem;font-size:.7rem;color:#63738a;overflow:hidden;margin-top:.3rem}.assets figcaption strong{overflow:hidden;text-overflow:ellipsis;white-space:nowrap;font-weight:600}.asset-meta{display:flex;gap:.5rem;color:#94a3b8;font-size:.68rem}.assets audio{display:block;width:100%;margin-top:2.5rem} .manager-controls{margin-top:1.25rem;border-top:1px solid #34465d;padding-top:1rem}.manager-heading{display:flex;justify-content:space-between;align-items:end;gap:1rem;color:#aab8cb;font-size:.75rem}.manager-heading div{display:flex;flex-direction:column;gap:.25rem}.manager-heading strong{color:#fff;font-size:.9rem}.control-actions{display:flex;flex-wrap:wrap;gap:.5rem;margin-top:.75rem}.control-actions button,.control-actions select{border:1px solid #526983;border-radius:7px;background:#243952;color:#fff;padding:.5rem .65rem;font-size:.75rem}.control-actions button{cursor:pointer}.control-actions button:disabled,.control-actions select:disabled{opacity:.55;cursor:not-allowed}.control-message{color:#bfdbfe;font-size:.75rem;margin-top:.65rem} .update-result{margin-top:.8rem;padding:.75rem;background:#243952;border:1px solid #526983;border-radius:8px;color:#dbeafe;font-size:.75rem}.update-result>strong{display:block;color:#fff;margin-bottom:.45rem}.update-result>div{margin-top:.45rem}.update-result ul{margin:.25rem 0 0 1.1rem;padding:0}.update-result small{color:#fecaca} diff --git a/frontend/src/app/pages/jobs.page.ts b/frontend/src/app/pages/jobs.page.ts index a4d7f99..22a1fef 100644 --- a/frontend/src/app/pages/jobs.page.ts +++ b/frontend/src/app/pages/jobs.page.ts @@ -125,4 +125,5 @@ export class JobsPage implements OnDestroy { formatBytes(value: number): string { if (!value) return '—'; return `${(value / 1073741824).toFixed(1)} GB`; } formatFileSize(value: number | null | undefined): string { if (!value) return '—'; if (value < 1024 * 1024) return `${(value / 1024).toFixed(0)} KB`; return `${(value / 1048576).toFixed(1)} MB`; } isVideo(asset: Asset): boolean { return asset.type === 'video'; } + isAudio(asset: Asset): boolean { return asset.type === 'audio'; } } diff --git a/server.js b/server.js index 2b99da7..6449907 100644 --- a/server.js +++ b/server.js @@ -45,7 +45,13 @@ function modelsFromPrompt(entry) { } return models.filter((model, index, all) => all.findIndex((item) => item.name === model.name) === index); } -function assetType(asset) { return /\.(mp4|webm|mov|m4v)$/i.test(asset.filename) ? 'video' : 'image'; } +function assetType(asset) { + const declaredType = String(asset?.type || '').toLowerCase(); + if (declaredType === 'audio' || declaredType === 'video' || declaredType === 'image') return declaredType; + if (/\.(mp3|flac|wav|ogg|oga|m4a|aac|opus)$/i.test(asset?.filename || '')) return 'audio'; + if (/\.(mp4|webm|mov|m4v)$/i.test(asset?.filename || '')) return 'video'; + return 'image'; +} function startComfyProgressSocket() { let WebSocket; try { WebSocket = require('ws'); } catch { return; } @@ -98,7 +104,13 @@ function startComfyProgressSocket() { function serverStatusFromStats(stats, queue) { const system = stats?.system || {}; const running = Array.isArray(queue?.queue_running) ? queue.queue_running.length : 0; const pending = Array.isArray(queue?.queue_pending) ? queue.queue_pending.length : 0; return { reachable: true, version: system.comfyui_version || '', os: system.os || '', pythonVersion: system.python_version || '', devices: (stats?.devices || []).map((device) => ({ name: device.name || device.type || 'Unknown device', type: device.type || '', vramTotal: device.vram_total || 0, vramFree: device.vram_free || 0 })), queue: { running, pending, total: running + pending } }; } function jobFromHistory(promptId, entry) { const outputs = Object.values(entry?.outputs || {}); - const assets = outputs.flatMap((output) => [...(output?.images || []), ...(output?.gifs || []), ...(output?.videos || [])]).filter((asset) => asset?.filename).map((asset) => ({ ...asset, type: assetType(asset), url: `/api/assets?filename=${encodeURIComponent(asset.filename)}&subfolder=${encodeURIComponent(asset.subfolder || '')}&type=${encodeURIComponent(asset.type || 'output')}` })); + const assets = outputs.flatMap((output) => [ + ...(output?.images || []), + ...(output?.gifs || []), + ...(output?.videos || []), + ...(output?.audio || []), + ...(output?.audios || []), + ]).filter((asset) => asset?.filename).map((asset) => ({ ...asset, type: assetType(asset), url: `/api/assets?filename=${encodeURIComponent(asset.filename)}&subfolder=${encodeURIComponent(asset.subfolder || '')}&type=${encodeURIComponent(asset.type || 'output')}` })); const metadata = extraData(entry); const progress = liveProgress.get(promptId); const startedAt = statusTimestamp(entry, 'execution_start') || executionStarts.get(promptId) || null; diff --git a/server.test.js b/server.test.js index b844664..6fced60 100644 --- a/server.test.js +++ b/server.test.js @@ -25,6 +25,31 @@ test('maps completed ComfyUI history into a read-only job summary', () => { assert.deepEqual(job, { promptId: 'abc123', title: 'Portrait', status: 'completed', queuedAt: 1000, completedAt: 3250, durationMs: 2250, outputCount: 1, assets: [{ filename: 'result.png', subfolder: '', type: 'image', url: '/api/assets?filename=result.png&subfolder=&type=output' }], models: [{ nodeId: '7', type: 'CheckpointLoaderSimple', name: 'portrait.safetensors' }], progress: null }); }); +test('maps ComfyUI audio outputs, including FLAC, into downloadable audio assets', () => { + const job = jobFromHistory('audio123', { + prompt: [1, 'audio123', {}, { title: 'Neo-soul piano' }], + status: { completed: true }, + outputs: { '9': { audio: [{ filename: 'neo_soul.flac', subfolder: '', type: 'output' }] } }, + }); + assert.equal(job.outputCount, 1); + assert.deepEqual(job.assets[0], { + filename: 'neo_soul.flac', + subfolder: '', + type: 'audio', + url: '/api/assets?filename=neo_soul.flac&subfolder=&type=output', + }); +}); + +test('recognises audio output arrays used by alternate ComfyUI nodes', () => { + const job = jobFromHistory('audio456', { + prompt: [1, 'audio456', {}, { title: 'Audio' }], + status: { completed: true }, + outputs: { '9': { audios: [{ filename: 'result.mp3', subfolder: 'music', type: 'output' }] } }, + }); + assert.equal(job.assets[0].type, 'audio'); + assert.match(job.assets[0].url, /filename=result.mp3/); +}); + test('classifies failed history without exposing mutation paths', () => { assert.equal(statusFromHistory({ status: { messages: [['execution_error', {}]] } }), 'failed'); });