From fd5c0a7645b5cee94942cfed2c39dde7367acbba Mon Sep 17 00:00:00 2001 From: "chris.dumas" Date: Mon, 26 Oct 2026 17:42:13 +0000 Subject: [PATCH] Expand persistent history UI coverage --- e2e/portal.spec.js | 77 +++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 76 insertions(+), 1 deletion(-) diff --git a/e2e/portal.spec.js b/e2e/portal.spec.js index 53d83bd..d9f5920 100644 --- a/e2e/portal.spec.js +++ b/e2e/portal.spec.js @@ -86,7 +86,10 @@ async function mockReadOnlyApi(page, { user = adminUser, jobs = [], running = nu if (jobs === 'unavailable') return route.fulfill({ status: 503, contentType: 'application/json', body: JSON.stringify({ error: 'Jobs unavailable' }) }); return route.fulfill({ status: 200, contentType: 'application/json', body: JSON.stringify({ jobs, running }) }); } - if (url.pathname === '/api/model-stats') return route.fulfill({ status: 200, contentType: 'application/json', body: JSON.stringify(stats) }); + if (url.pathname === '/api/model-stats') { + if (stats === 'unavailable') return route.fulfill({ status: 502, contentType: 'application/json', body: JSON.stringify({ error: 'History unavailable' }) }); + return route.fulfill({ status: 200, contentType: 'application/json', body: JSON.stringify(stats) }); + } if (url.pathname === '/api/server-status') { if (server === 'unavailable') return route.fulfill({ status: 502, contentType: 'application/json', body: JSON.stringify({ error: 'ComfyUI is unavailable right now.' }) }); return route.fulfill({ status: 200, contentType: 'application/json', body: JSON.stringify({ status: server }) }); @@ -321,4 +324,76 @@ test.describe('ComfyUI Portal read-only UI states', () => { await expect(page.getByText('Update all started. Checking progress…')).toBeVisible(); await expect.poll(() => requestCount).toBe(1); }); + + test('shows an empty model-history state when no jobs have been archived', async ({ page }) => { + await mockReadOnlyApi(page, { stats: { totalJobs: 0, totalModels: 0, models: [] } }); + await page.goto('/jobs'); + await expect(page.getByText('0 tracked jobs · 0 models')).toBeVisible(); + await expect(page.getByText('No model usage has been recorded yet.')).toBeVisible(); + await expect(page.locator('.stats-list')).toHaveCount(0); + }); + + test('keeps the model panel usable when its stats request fails', async ({ page }) => { + await mockReadOnlyApi(page, { stats: 'unavailable' }); + await page.goto('/jobs'); + await expect(page.getByRole('heading', { name: 'Most used models' })).toBeVisible(); + await expect(page.getByText('No model usage has been recorded yet.')).toBeVisible(); + }); + + test('preserves model names and job counts in rank order', async ({ page }) => { + const stats = { totalJobs: 7, totalModels: 3, models: [{ name: 'popular.safetensors', jobCount: 5 }, { name: 'second.safetensors', jobCount: 2 }, { name: 'rare.safetensors', jobCount: 1 }] }; + await mockReadOnlyApi(page, { stats }); + await page.goto('/jobs'); + const rows = page.locator('.stats-list li'); + await expect(rows).toHaveCount(3); + await expect(rows.nth(0)).toContainText('popular.safetensors'); + await expect(rows.nth(0)).toContainText('5 jobs'); + await expect(rows.nth(1)).toContainText('second.safetensors'); + await expect(rows.nth(1)).toContainText('2 jobs'); + await expect(rows.nth(2)).toContainText('rare.safetensors'); + await expect(rows.nth(2)).toContainText('1 job'); + }); + + test('renders multiple output assets in one completed job', async ({ page }) => { + const jobs = [{ promptId: 'multi-output', title: 'Multi output', status: 'completed', queuedAt: 1000, durationMs: 4000, outputCount: 2, assets: [ + { filename: 'frame.png', url: '/api/assets?filename=frame.png&subfolder=&type=output', type: 'image' }, + { filename: 'clip.mp4', url: '/api/assets?filename=clip.mp4&subfolder=&type=output', type: 'video' }, + ], models: [], progress: null }]; + await mockReadOnlyApi(page, { jobs }); + await page.goto('/jobs'); + await expect(page.getByRole('heading', { name: 'Multi output' })).toBeVisible(); + await expect(page.locator('figure')).toHaveCount(2); + await expect(page.locator('img[alt="frame.png"]')).toBeVisible(); + await expect(page.locator('video')).toBeVisible(); + await expect(page.getByText('2 outputs')).toBeVisible(); + }); + + test('keeps an asset usable when metadata lookup fails', async ({ page }) => { + const jobs = [{ promptId: 'asset-meta-error', title: 'Metadata unavailable', status: 'completed', queuedAt: 1000, durationMs: 1000, outputCount: 1, assets: [{ filename: 'unknown.png', url: '/api/assets?filename=unknown.png&subfolder=&type=output', type: 'image' }], models: [], progress: null }]; + await mockReadOnlyApi(page, { jobs }); + await page.route('**/api/assets/meta**', async route => route.fulfill({ status: 502, contentType: 'application/json', body: JSON.stringify({ error: 'Metadata unavailable' }) })); + await page.goto('/jobs'); + await expect(page.getByText('unknown.png')).toBeVisible(); + await expect(page.getByText('1280 × 720')).toHaveCount(0); + await expect(page.getByText('2.0 MB')).toHaveCount(0); + }); + + test('shows queue counts for pending and running work', async ({ page }) => { + const server = { ...connectedServer, queue: { running: 1, pending: 3, total: 4 } }; + await mockReadOnlyApi(page, { server }); + await page.goto('/jobs'); + await expect(page.getByText('4', { exact: true })).toBeVisible(); + await expect(page.getByText('3', { exact: true })).toBeVisible(); + await expect(page.getByText('1', { exact: true })).toBeVisible(); + }); + + test('reports a mocked Manager rejection without leaving controls stuck', async ({ page }) => { + await mockReadOnlyApi(page); + await page.route('**/api/comfy/update-all', async route => route.fulfill({ status: 502, contentType: 'application/json', body: JSON.stringify({ error: 'Manager rejected update' }) })); + await page.goto('/jobs'); + page.once('dialog', dialog => dialog.accept()); + await page.getByRole('button', { name: 'Update all' }).click(); + await expect(page.getByText('Manager rejected update')).toBeVisible(); + await expect(page.getByRole('button', { name: 'Update all' })).toBeEnabled(); + }); });