fix(v3.8): restore review continuation and prefix resume
This commit is contained in:
@@ -20,7 +20,7 @@ jobs:
|
||||
run: |
|
||||
python -m pip install --upgrade pip
|
||||
python -m pip install --index-url https://download.pytorch.org/whl/cpu torch
|
||||
python -m pip install -r requirements.txt numpy safetensors pytest psutil
|
||||
python -m pip install -r requirements.txt numpy safetensors pytest psutil opencv-python-headless Pillow
|
||||
- name: Compile Python
|
||||
run: python -m compileall -q .
|
||||
- name: Run tests
|
||||
|
||||
+9
-9
@@ -1,9 +1,9 @@
|
||||
dca65fb1393e67f59c6f81f9411e3e745eb8f1097e9a2adf7ffc6f4e3901ca9f __init__.py
|
||||
3e7a1ec3380be2a222c8a3e9b8a6bb184d3a760478957f48186438f15235bdba branch_provenance.py
|
||||
4f6feeb2f63a9285b0e76fb2e2618058c7d7c279af1632e1a6ccabcc9ec9a45a .github/workflows/tests.yml
|
||||
8296f0afc7be47171e439c02fb2988cfeb0df904acbe3fc4f507f426d709157e .github/workflows/tests.yml
|
||||
0a2f69d4cec89d440f5d5aa1ec68a7c9a741382d313f80dcddf96d13f70b3e68 .gitignore
|
||||
e0d0093229dd4719e97e1ee2c0cf935f6692f323f97af49a6361fd9ffac8a3d2 AGENTS.md
|
||||
2794b4f4831e5ec9a38b6cb3049736c16d800708057349e80e1a921c90d16a2e CHANGELOG.md
|
||||
2794b4f4831e5ec9a38b6cb3049736c16d800708057349e80e1a921c90d16a2e CHANGELOG.md
|
||||
c1ed3a0342730450958fb62fd21854a876991f3a4aefb24e5383b0c73cd2312d compatibility.py
|
||||
4d62508f900af9f93ec320afb900c27cc9a300d1e0c0a94714258498c5ede5fc conditioning.py
|
||||
64967f4987e3ad9316f3a47f0dcf582eeff39ee0c3485f4184d3532d495534ae constants.py
|
||||
@@ -87,12 +87,12 @@ b470819f16fc179654dc1600721a63f0a5a14e777f4c004d574b499da6886ba5 public_api.py
|
||||
96f98d727b72d6aefd431061572e187c303365a3e5b4d20cbb2bcf030aa30112 pyproject.toml
|
||||
94fdc2d545b2d4077a4d70229fd22ba3ccac21d49d1097d2873f76d04e9a3c7a pytest.ini
|
||||
88aa955161d04d14ebd8d90d6cb6c6206097160a671eb4d1bfe9b3e76ebc6c13 README_JA.md
|
||||
1f8a6e1a4441ac2fd7a07ddbdfea923ed1da9f3100db49dca729e141de92f4af README.md
|
||||
9d9fa5ec9db29e2fb52e3c5ed26df02c9c0c2ba39608294f7c62057237830908 README.md
|
||||
44127adcfa30ee84bff9cd4b2d0c695355209550e76982d374122008728aa5bc reference_audio.py
|
||||
5cb9bfd6810d3a93a637451980a4cc5c1436e5b84cfd1c7a111cd192e876351b reference_video.py
|
||||
131bdfbb7a7173c9e7826859c0e648bfb69bd18bf20fa5528c0e18a63f888b26 reference.py
|
||||
467edb2c188d024c2392aafe7423b3f835e16b10f570da76e2f7dda8a962c1c5 requirements.txt
|
||||
a65d657466491aba8b2d1004e87071cee2819869813e646789df736a3ccf479e run_storage.py
|
||||
2ceba1091dad4fa66da7299e8320ff0a8a6dccb948fc918e3101b40f6d8b03f6 run_storage.py
|
||||
6056de6c0a5322a8a51ba5a114538dca2ef67788cd1afba10fedd483b95f6afa state_io.py
|
||||
3a359a0467725cc292ccb4c86cf0c3d30bb6a114d01f5345792b09ea3d45441d state.py
|
||||
43ec4023dc06c941e5d7a04db4b8a89fb58d744ceb986f6eb9bf534d4fdcb87b temporal.py
|
||||
@@ -172,8 +172,8 @@ cff84ae0562ba5fc48f3608ecaa433e74c0af9b689d7dca94ec8c3c4e9dc232f tests/test_v38
|
||||
ee4dd8f6eb8114706b2625b4471b041a0ea66198f9f825c63e913c896ed87530 tests/test_v38_branch_provenance.py
|
||||
72a0e3cb334049b66dd36f52c826931067c242fa63557933fd667138b38d6e8d tests/test_v38_review_control.py
|
||||
83301839f08d275f5648d7782b6d96795e14b1ce79d722e83e57190fe52fb4aa tests/test_v38_review_execution_cap.py
|
||||
2fec519540e18c55682884647db9fa1c90902da7be3d62261f2801a5c5724a96 tests/test_v38_review_run_storage.py
|
||||
b228d1a596ade2c3b3495fdf97177e798cec4be774d6ff02d5c6294e09140866 tests/test_v38_review_ui.py
|
||||
2fec519540e18c55682884647db9fa1c90902da7be3d62261f2801a5c5724a96 tests/test_v38_review_run_storage.py
|
||||
dfa174feed4b14d819d1c9f36381e5650e97da6d0e59de441895955dd107ff5f tests/test_v38_review_ui.py
|
||||
75697036f361a9b8ea74f69b15e408670f686c8c0e8a6c1d48fe059cc837d12a tests/test_v38_selective_second_pass_node.py
|
||||
8026a241301dfc4de518649305458a538ef17a0b1567b113877a2af377738528 tests/test_v38_temporal_window_refine.py
|
||||
0dbe8a5f71c92f3523942343b40787104c8b96781461ba3ba82934a6bdbe5834 THIRD_PARTY_NOTICES.md
|
||||
@@ -241,12 +241,12 @@ c2883272b05a9a9146b5c6cf614ddae8a3e6893cd910902023aae61360195289 web/easy_bypas
|
||||
9db0aa94f634578a962d5db49e5c70356040a59df968e3a2e531b327a623081f web/easy_load_image.js
|
||||
873efcbd15c2d9fa10c9d5fc51a796ad3a18c0c6acceecf499c4b956aa845c6c web/easy_load_video.js
|
||||
0c68d13a1f8beb7431a32b471f8b0612c42fcc4bf72dd97611a025d158008662 web/easy_v38.js
|
||||
549a8150bc926bf142758b1610e3730547d6abcfbcddb0b37ed8baaaf86b38cb web/project_id.js
|
||||
613797b621f07813b7c13417766f6f87aab92eb4c049ddd692577b226f46a894 web/project_id.js
|
||||
be0b8d39e5343680ebea815c3a4fb6ce7a32e065f30e43e013040a40f702cef3 .comfyignore
|
||||
1d2838cc47694609289ea15132872ad48e1b6c8274da4b7bf188dd3ebf066121 docs/V38_RELEASE_AND_MIGRATION.md
|
||||
69d0e95d4d8ed8414e9bfb9bbbcb6183efa6d27f27cc8c6dd2f84c9cc5ce3439 tests/test_v38_public_surface_cleanup.py
|
||||
69d0e95d4d8ed8414e9bfb9bbbcb6183efa6d27f27cc8c6dd2f84c9cc5ce3439 tests/test_v38_public_surface_cleanup.py
|
||||
0cf8d49bcb71b30437dc893f6218dc4cfb1cd244b647e4fbc2861dea2271a33a web/reference_audio_ui.js
|
||||
88a9426baa14dc99ecd643cdf58e46e780672d86088b2897aa66952c56b3c126 REGISTRY_MANIFEST.sha256
|
||||
88a9426baa14dc99ecd643cdf58e46e780672d86088b2897aa66952c56b3c126 REGISTRY_MANIFEST.sha256
|
||||
717577efdec5e61600504b77bc2a099ef022c4fe2333e936c3310c7182d8f2a0 docs/V38_OPEN_INTEGRATION_CONTRACT.md
|
||||
623d528a02b6712cba28c374ba3ad979bc84e2ac5318640692589a04ba6ab15f tests/test_v38_open_integration_contract.py
|
||||
0bc369ee428b8a5bc8e370a81fbab427262a1fdb7805a78c442c91698d65efba tools/__init__.py
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
|
||||
**Download workflow: [JSON](examples/workflows/MiniMax_H3_Continuum_V38.json) | [ZIP](examples/workflows/MiniMax_H3_Continuum_V38.zip)** — [Latest release](https://github.com/ukr8b3g-cmyk/ComfyUI-H3-Continuum/releases/latest)
|
||||
|
||||
⚠️ Hotfix in progress: We’re investigating reported issues with chunk continuation and Review Each Chunk mode in V3.8. A hotfix is being prepared. Thank you for your reports and patience—we’ll update this page when it’s ready.
|
||||
✅ V3.8 hotfix applied on `main` — September 8, 2026: Review Each Chunk continuation, stale `Regenerate From` state, completed-sequence extension, and Render History queue handling have been repaired. Update with `git pull --ff-only origin main` (or ComfyUI Manager **Update**), restart ComfyUI, and hard-refresh the browser if the old UI remains. Existing saved Takes are preserved. Issue #13 remains a separate open long-continuation quality issue and is not part of this hotfix.
|
||||
|
||||
<img width="1536" height="1024" alt="exec-55ad0463-8655-409c-b9a6-49d1315cdd78" src="https://github.com/user-attachments/assets/063bb16b-5c25-44f8-9304-031995502b26" />
|
||||
|
||||
@@ -463,23 +463,35 @@ If you want a review pause instead, choose `Run = Review Each Chunk` in step 6.
|
||||
|
||||
#### 9. Add more chunks to a completed sequence
|
||||
|
||||
For a compatible saved run without a Last Image constraint, increasing the target can reuse completed chunks. This requires saved progress, not just an existing MP4 file.
|
||||
**You do not need Render History just to make a completed video longer.** For an ordinary extension, go back to the normal settings, increase the target `Chunks`, and Queue again. `Chunks` is the **final total number of chunks**, not the number you want to add next.
|
||||
|
||||
1. Keep the same Sampler/workflow and `Run Name (Optional Override)`. Do not create a new run identity.
|
||||
2. Keep `Base Seed` unchanged and `Control After Generate = fixed`.
|
||||
3. Keep `Progress = On — Resume and Takes available`, and keep the saved progress files available.
|
||||
4. Keep `Seconds per Chunk` and the generation inputs unchanged.
|
||||
5. Set `Regenerate From = Auto`.
|
||||
6. Change **only the target count** in `Chunks`: for example, change `3` to `5` to add two chunks. Do not set it to `2`.
|
||||
7. Choose `Run = Review Each Chunk` for one new review unit per Queue, or `Run = Generate Full Video` to finish all missing chunks.
|
||||
8. Check `Total Length`, then click the top-right blue `Run` button and check the reuse report described below.
|
||||
For the simplest and safest extension, keep the existing generation conditions unchanged: the same Sampler/workflow and run identity, `Base Seed`, `Control After Generate = fixed`, `Seconds per Chunk`, prompt, model/LoRA, media, dimensions, sampling schedule, Continuity, and Audio Continuity. Keep `Progress = On — Resume and Takes available` and `Regenerate From = Auto`.
|
||||
|
||||
With compatible progress for three 5-second chunks, the new target is 25 seconds. Review mode should first produce Chunk 4 and a 20-second output; continuing again completes Chunk 5. Full-video mode should produce Chunks 4–5 and the 25-second output in one Queue.
|
||||
**Example: extend a completed 2 × 5-second sequence to 3 × 5 seconds**
|
||||
|
||||
**Do not assume append-only reuse with Last Image.** Extending a sequence changes where its final-image constraint belongs. The former last chunk, or a terminal pair, may need regeneration. Likewise, changing the model, prompt, media, dimensions, schedule, or continuation settings can invalidate saved progress. `Progress = On` enables compatibility checking; it does not force incompatible chunks to be reused.
|
||||
1. Finish the original two chunks. The completed target is `Chunks = 2`, so the saved video is 10 seconds.
|
||||
2. Click `Back to Settings`. You do **not** need to open `Render History`.
|
||||
3. Change `Chunks` from `2` to `3`. `Total Length` changes from 10 seconds to 15 seconds.
|
||||
4. Keep `Progress = On — Resume and Takes available` and `Regenerate From = Auto`. Keep the prompt and the existing generation inputs unchanged for this ordinary extension.
|
||||
5. Use `Run = Review Each Chunk` if you want to review the new chunk, or `Run = Generate Full Video` if you want all currently missing chunks generated in one Queue.
|
||||
6. Click the top-right blue `Run` button.
|
||||
|
||||
With compatible saved progress, the expected work is:
|
||||
|
||||
- Chunk 1 → reused; no new Sampling
|
||||
- Chunk 2 → reused; no new Sampling
|
||||
- Chunk 3 → newly generated
|
||||
- final saved sequence → 3 chunks / 15 seconds
|
||||
|
||||
The same rule applies to a larger extension. For example, changing `Chunks` from `3` to `5` means the new target is five total chunks; it does **not** mean “add five.” Review mode first generates Chunk 4, then Chunk 5 on the next accepted continuation. Full-video mode generates the missing Chunks 4–5 in one Queue.
|
||||
|
||||
Switching `Generate Full Video` ↔ `Review Each Chunk` by itself does **not** mean restart from Chunk 1. A Chunk 1 restart happens only when you explicitly choose `Start again from Chunk 1`, explicitly set Advanced `Regenerate From = Chunk 1`, or the backend determines that the stored prefix is incompatible with the current generation contract.
|
||||
|
||||
`Render History` is for a different job: browsing stored Takes, selecting an older Take, or branching with `Continue From Here`. Normal append-style extension does not require History. `Previous Take` / `Next Take` only browse stored results; they do not generate a new chunk.
|
||||
|
||||
**Do not assume append-only reuse with Last Image.** Extending a sequence changes where its final-image constraint belongs. The former last chunk, or a terminal pair, may need regeneration. Likewise, changing the prompt or other generation-contract inputs can invalidate saved progress. `Progress = On` enables compatibility checking; it does not force incompatible chunks to be reused.
|
||||
|
||||
The extension path is covered by CPU compatibility tests, including two-to-three chunks and Last Image invalidation. It is not the same GPU test as the two-chunk review timing example below; arbitrary extensions and media combinations have not all been GPU-verified.
|
||||
|
||||
#### 10. Understand continuation time and check reuse
|
||||
|
||||
Continuing does not mean saving only the new segment. With compatible saved progress, the normal workflow:
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
dca65fb1393e67f59c6f81f9411e3e745eb8f1097e9a2adf7ffc6f4e3901ca9f __init__.py
|
||||
be0b8d39e5343680ebea815c3a4fb6ce7a32e065f30e43e013040a40f702cef3 .comfyignore
|
||||
3e7a1ec3380be2a222c8a3e9b8a6bb184d3a760478957f48186438f15235bdba branch_provenance.py
|
||||
2794b4f4831e5ec9a38b6cb3049736c16d800708057349e80e1a921c90d16a2e CHANGELOG.md
|
||||
2794b4f4831e5ec9a38b6cb3049736c16d800708057349e80e1a921c90d16a2e CHANGELOG.md
|
||||
c1ed3a0342730450958fb62fd21854a876991f3a4aefb24e5383b0c73cd2312d compatibility.py
|
||||
4d62508f900af9f93ec320afb900c27cc9a300d1e0c0a94714258498c5ede5fc conditioning.py
|
||||
64967f4987e3ad9316f3a47f0dcf582eeff39ee0c3485f4184d3532d495534ae constants.py
|
||||
@@ -28,12 +28,12 @@ a4ce23167b83e8d72b86a802dfde4f4045828433c7c13aab799bd64831dc04a4 nodes.py
|
||||
b470819f16fc179654dc1600721a63f0a5a14e777f4c004d574b499da6886ba5 public_api.py
|
||||
96f98d727b72d6aefd431061572e187c303365a3e5b4d20cbb2bcf030aa30112 pyproject.toml
|
||||
88aa955161d04d14ebd8d90d6cb6c6206097160a671eb4d1bfe9b3e76ebc6c13 README_JA.md
|
||||
1f8a6e1a4441ac2fd7a07ddbdfea923ed1da9f3100db49dca729e141de92f4af README.md
|
||||
9d9fa5ec9db29e2fb52e3c5ed26df02c9c0c2ba39608294f7c62057237830908 README.md
|
||||
44127adcfa30ee84bff9cd4b2d0c695355209550e76982d374122008728aa5bc reference_audio.py
|
||||
5cb9bfd6810d3a93a637451980a4cc5c1436e5b84cfd1c7a111cd192e876351b reference_video.py
|
||||
131bdfbb7a7173c9e7826859c0e648bfb69bd18bf20fa5528c0e18a63f888b26 reference.py
|
||||
467edb2c188d024c2392aafe7423b3f835e16b10f570da76e2f7dda8a962c1c5 requirements.txt
|
||||
a65d657466491aba8b2d1004e87071cee2819869813e646789df736a3ccf479e run_storage.py
|
||||
2ceba1091dad4fa66da7299e8320ff0a8a6dccb948fc918e3101b40f6d8b03f6 run_storage.py
|
||||
6056de6c0a5322a8a51ba5a114538dca2ef67788cd1afba10fedd483b95f6afa state_io.py
|
||||
3a359a0467725cc292ccb4c86cf0c3d30bb6a114d01f5345792b09ea3d45441d state.py
|
||||
43ec4023dc06c941e5d7a04db4b8a89fb58d744ceb986f6eb9bf534d4fdcb87b temporal.py
|
||||
@@ -100,6 +100,6 @@ c2883272b05a9a9146b5c6cf614ddae8a3e6893cd910902023aae61360195289 web/easy_bypas
|
||||
9db0aa94f634578a962d5db49e5c70356040a59df968e3a2e531b327a623081f web/easy_load_image.js
|
||||
873efcbd15c2d9fa10c9d5fc51a796ad3a18c0c6acceecf499c4b956aa845c6c web/easy_load_video.js
|
||||
0c68d13a1f8beb7431a32b471f8b0612c42fcc4bf72dd97611a025d158008662 web/easy_v38.js
|
||||
549a8150bc926bf142758b1610e3730547d6abcfbcddb0b37ed8baaaf86b38cb web/project_id.js
|
||||
613797b621f07813b7c13417766f6f87aab92eb4c049ddd692577b226f46a894 web/project_id.js
|
||||
0cf8d49bcb71b30437dc893f6218dc4cfb1cd244b647e4fbc2861dea2271a33a web/reference_audio_ui.js
|
||||
83d28cc0cd549066962dc21ceae05d2b189fe22391b556887eab2cc1800e1e80 examples/workflows/MiniMax_H3_Continuum_V38.zip
|
||||
|
||||
+1392
-1128
File diff suppressed because it is too large
Load Diff
@@ -187,7 +187,7 @@ async function load(n,p) {project=p;await loadTakeHistory(n);n.__h3ContinuumIntu
|
||||
prepareReviewQueueIntent(setup,inputs);
|
||||
assert.equal(inputs.review_action,"Continue / Next");
|
||||
if(["complete","review_ready"].includes(oldStatus)){
|
||||
assert.equal(inputs.reroll_from_chunk,"Chunk 1","saved history starts a new review branch");
|
||||
assert.equal(inputs.reroll_from_chunk,"Auto","mode switch preserves compatible continuation");
|
||||
assert.equal(inputs.reroll_nonce,0);
|
||||
assert.equal(inputs.take_group,0);
|
||||
assert.equal(inputs.take_revision_id,"");
|
||||
@@ -195,7 +195,7 @@ async function load(n,p) {project=p;await loadTakeHistory(n);n.__h3ContinuumIntu
|
||||
}
|
||||
await load(setup,old);
|
||||
assert(visible(setup,"Chunks"),"Queue alone does not mean generation completed");
|
||||
project=state("review_ready",{start:1,end:1,physical_group:1},"new-output");
|
||||
project=state("review_ready",{start:2,end:2,physical_group:2},"new-output");
|
||||
setup.onExecuted();
|
||||
await new Promise(resolve=>setImmediate(resolve));
|
||||
assert(buttons.every(name=>visible(setup,name)),"new queued result opens ordinary review");
|
||||
@@ -234,53 +234,79 @@ async function load(n,p) {project=p;await loadTakeHistory(n);n.__h3ContinuumIntu
|
||||
// Frontend 1.49 contract: widget.beforeQueued runs before serializeValue;
|
||||
// legacy beforeQueuePrompt is not part of the real queue path.
|
||||
const liveContract=makeNode();liveContract.id=312;app.graph._nodes=[liveContract];
|
||||
w(liveContract,"chunks").value=4;
|
||||
await load(liveContract,state("complete",{start:3,end:3,physical_group:3},"live-old-complete"));
|
||||
w(liveContract,"Run").callback("Generate Full Video");
|
||||
w(liveContract,"Run").callback("Review Each Chunk");
|
||||
for(const widget of liveContract.widgets)widget.beforeQueued?.({isPartialExecution:false});
|
||||
const liveInputs=await serializedInputs(liveContract);
|
||||
assert.equal(liveInputs.reroll_from_chunk,"Chunk 1");
|
||||
assert.equal(liveInputs.reroll_from_chunk,"Auto","mode switch must not inject Chunk 1");
|
||||
assert.equal(liveInputs.reroll_nonce,0);
|
||||
assert.equal(liveInputs.take_group,0);
|
||||
assert.equal(liveInputs.take_revision_id,"");
|
||||
assert.equal(liveInputs.take_action,"Automatic");
|
||||
assert.equal(liveInputs.review_action,"Continue / Next");
|
||||
assert.equal(w(liveContract,"reroll_from_chunk").value,"Auto","visible settings stay unchanged");
|
||||
project=state("review_ready",{start:1,end:1,physical_group:1},"live-fresh-chunk-1");
|
||||
emit("executed",{node:"312",prompt_id:"live-prompt"});
|
||||
project=state("review_ready",{start:4,end:4,physical_group:4},"live-fresh-chunk-4");
|
||||
// Sampler V3.8 does not need to emit a node-specific `executed` UI event.
|
||||
emit("execution_success",{prompt_id:"live-prompt"});
|
||||
await new Promise(resolve=>setTimeout(resolve,20));
|
||||
assert(buttons.every(name=>visible(liveContract,name)),"real completion events open Chunk 1 review");
|
||||
assert.match(w(liveContract,"Review Ready").value,/Chunk 1/);
|
||||
// Acceptance lifecycle: 3 x 5 seconds must stop at every review boundary.
|
||||
const flow=makeNode();w(flow,"chunks").value=3;w(flow,"chunk_seconds").value=5;
|
||||
assert(buttons.every(name=>visible(liveContract,name)),"terminal readback opens the new review");
|
||||
assert.match(w(liveContract,"Review Ready").value,/Chunk 4/);
|
||||
// Acceptance lifecycle: extend a completed 3 x 5-second prefix to 5 x 5 seconds.
|
||||
const flow=makeNode();w(flow,"chunks").value=5;w(flow,"chunk_seconds").value=5;
|
||||
await load(flow,state("complete",{start:3,end:3,physical_group:3},"old-complete-3x5"));
|
||||
w(flow,"Run").callback("Generate Full Video");
|
||||
w(flow,"Run").callback("Review Each Chunk");
|
||||
const chunk1Inputs={reroll_from_chunk:"Auto",reroll_nonce:0};
|
||||
prepareReviewQueueIntent(flow,chunk1Inputs);
|
||||
assert.equal(chunk1Inputs.reroll_from_chunk,"Chunk 1");
|
||||
project=state("review_ready",{start:1,end:1,physical_group:1},"fresh-chunk-1");
|
||||
const chunk4Inputs={reroll_from_chunk:"Auto",reroll_nonce:0,
|
||||
take_group:9,take_revision_id:"stale",take_action:"Use This Take"};
|
||||
prepareReviewQueueIntent(flow,chunk4Inputs);
|
||||
assert.equal(chunk4Inputs.reroll_from_chunk,"Auto","extension reuses the compatible prefix");
|
||||
assert.equal(chunk4Inputs.take_group,0);
|
||||
assert.equal(chunk4Inputs.take_revision_id,"");
|
||||
assert.equal(chunk4Inputs.take_action,"Automatic");
|
||||
project=state("review_ready",{start:4,end:4,physical_group:4},"fresh-chunk-4");
|
||||
flow.onExecuted();await new Promise(resolve=>setImmediate(resolve));
|
||||
assert(buttons.every(name=>visible(flow,name)),"Chunk 1 opens the review screen");
|
||||
assert.match(w(flow,"Review Ready").value,/Chunk 1/);
|
||||
assert(buttons.every(name=>visible(flow,name)),"Chunk 4 opens the review screen");
|
||||
assert.match(w(flow,"Review Ready").value,/Chunk 4/);
|
||||
w(flow,"Use it and continue").callback();
|
||||
const chunk2Inputs={reroll_from_chunk:"Auto",reroll_nonce:0};
|
||||
prepareReviewQueueIntent(flow,chunk2Inputs);
|
||||
assert.equal(chunk2Inputs.reroll_from_chunk,"Auto","continuation does not restart Chunk 1");
|
||||
project=state("review_ready",{start:2,end:2,physical_group:2},"fresh-chunk-2");
|
||||
const chunk5Inputs={reroll_from_chunk:"Auto",reroll_nonce:0};
|
||||
prepareReviewQueueIntent(flow,chunk5Inputs);
|
||||
assert.equal(chunk5Inputs.reroll_from_chunk,"Auto","continuation does not restart Chunk 1");
|
||||
project=state("complete",{start:5,end:5,physical_group:5},"fresh-chunk-5");
|
||||
flow.onExecuted();await new Promise(resolve=>setImmediate(resolve));
|
||||
assert(buttons.every(name=>visible(flow,name)),"Chunk 2 opens the review screen");
|
||||
assert.match(w(flow,"Review Ready").value,/Chunk 2/);
|
||||
w(flow,"Use it and continue").callback();
|
||||
const chunk3Inputs={reroll_from_chunk:"Auto",reroll_nonce:0};
|
||||
prepareReviewQueueIntent(flow,chunk3Inputs);
|
||||
assert.equal(chunk3Inputs.reroll_from_chunk,"Auto");
|
||||
project=state("complete",{start:3,end:3,physical_group:3},"fresh-chunk-3");
|
||||
flow.onExecuted();await new Promise(resolve=>setImmediate(resolve));
|
||||
assert(visible(flow,"Try this chunk again"),"Chunk 3 completion remains reviewable");
|
||||
assert(visible(flow,"Try this chunk again"),"Chunk 5 completion remains reviewable");
|
||||
assert(!visible(flow,"Use it and continue")&&!visible(flow,"Use it and finish the rest"));
|
||||
assert.match(w(flow,"Review Ready").value,/Saved sequence is complete/);
|
||||
|
||||
// Full mode also keeps Auto so the backend can reuse Chunks 1-3 and generate 4-5.
|
||||
const fullExtend=makeNode();w(fullExtend,"chunks").value=5;
|
||||
await load(fullExtend,state("complete",{start:3,end:3,physical_group:3},"full-old-3"));
|
||||
w(fullExtend,"Run").callback("Generate Full Video");
|
||||
const fullInputs={reroll_from_chunk:"Auto",reroll_nonce:0};prepareReviewQueueIntent(fullExtend,fullInputs);
|
||||
assert.equal(fullInputs.generation_mode,"Full Run");
|
||||
assert.equal(fullInputs.reroll_from_chunk,"Auto");
|
||||
|
||||
// Storage Off cannot submit a stale explicit regeneration boundary.
|
||||
const storageOff=makeNode();
|
||||
w(storageOff,"generation_mode").value="Full Run";
|
||||
w(storageOff,"run_storage").value="Off";
|
||||
w(storageOff,"reroll_from_chunk").value="Chunk 1";
|
||||
w(storageOff,"reroll_nonce").value=7;
|
||||
for(const widget of storageOff.widgets)widget.beforeQueued?.({isPartialExecution:false});
|
||||
const offInputs=await serializedInputs(storageOff);
|
||||
assert.equal(offInputs.reroll_from_chunk,"Auto");
|
||||
assert.equal(offInputs.reroll_nonce,0);
|
||||
assert.equal(w(storageOff,"reroll_from_chunk").value,"Auto","visible stale boundary is normalized");
|
||||
|
||||
// An explicit Advanced regeneration remains explicit while storage is enabled.
|
||||
const explicit=makeNode();
|
||||
w(explicit,"reroll_from_chunk").value="Chunk 1";
|
||||
w(explicit,"reroll_from_chunk").callback?.("Chunk 1");
|
||||
w(explicit,"Run").callback("Generate Full Video");
|
||||
w(explicit,"Run").callback("Review Each Chunk");
|
||||
for(const widget of explicit.widgets)widget.beforeQueued?.({isPartialExecution:false});
|
||||
const explicitInputs=await serializedInputs(explicit);
|
||||
assert.equal(explicitInputs.reroll_from_chunk,"Chunk 1","manual Advanced regeneration is preserved");
|
||||
// Hotfix: stale saved review cannot offer/submit Retry after settings edits.
|
||||
const edited=makeNode();w(edited,"chunks").value=4;
|
||||
const originalProject=state("review_ready",{start:2,end:2,physical_group:2},"edit-base");
|
||||
|
||||
@@ -1096,7 +1096,7 @@ def test_n2c_history_refresh_hooks_and_multiline_surface_are_present():
|
||||
source = PROJECT_ID_JS.read_text(encoding="utf-8")
|
||||
assert '"Render History / Takes"' in source
|
||||
assert '{ multiline: true }' in source
|
||||
assert "void loadTakeHistory(this);" in source
|
||||
assert "loadTakeHistory(this)" in source
|
||||
assert "attachTakeHistoryReload(node);" in source
|
||||
assert "node.__h3ContinuumTakeInitialLoad" in source
|
||||
assert 'const TAKE_TOGGLE_WIDGET = "Render History";' in source
|
||||
|
||||
+452
-390
File diff suppressed because it is too large
Load Diff
Reference in New Issue
Block a user